bsdinstall: add pkgbase prompt to jail script

[ifreund_freebsdfoundation.org]

Use bsdinstall pkgbase --no-kernel, reword prompt

[jhb]

I wonder if instead of non_pkgbase you want something like distbase which installs the base system using distribution tarballs? The dialog here would then ask something more like: "Would you like to install the base system using traditional distribution tarballs or packages (experimental)?"

[jhb]

usr.sbin/bsdinstall/scripts/jail

138

Maybe "Packages" instead of "PkgBase"? I think "PkgBase" will not age well. It's more like "Tarballs (Traditional)" vs "Packages (Experimental)" IMO

[emaste]

usr.sbin/bsdinstall/scripts/jail

56

Continuing the naming theme, I think "dist sets" are a decent name for traditional/tarball/non-pkgbase installation artifacts. Maybe install_dist_sets

[jhb]

usr.sbin/bsdinstall/scripts/jail

56

I was thinking distbase vs pkgbase, but that could also work.

134–139

This logic is also too convoluted. I would rather you do something like:

basemode=dist
if [ "$nonInteractive" != "YES" ]; then
    bsddialog ...
    if [ $? -eq 1 ]; then
         basemode=pkg
    fi
fi

case "$basemode" in
    dist)
         distbase
         ;;
    pkg)
         bsdinstall pkgbase --no-kernel
         ;;
esac

Or some such.

[ifreund_freebsdfoundation.org]

Tweak wording based on jhb review, simplify logic

[ifreund_freebsdfoundation.org]

Thanks for the review @jhb!

usr.sbin/bsdinstall/scripts/jail

134–139

This should be better now and also matches the control flow in auto more closely with the introduction of a PKGBASE variable.

138

I think your suggested changes to the wording of this prompt are great, I was not happy with "PkgBase" but didn't consider "Packages" as an alternative.

I've gone with simply "Traditional" for the other option as both "Tarballs" and "Dist Sets" feel too jargony to me. Let me know what you think.

[emaste]

New wording LGTM

[emaste]

A couple of whitespace nits (which I can just fix and roll in) but otherwise lgtm

usr.sbin/bsdinstall/scripts/jail

73

Looks like misaligned whitespace here

77

And here, these should be tab-tab-tab-space-space-space-space I expect

136

And here, tab-space-space-space-space