sendfile: factor out socket send buffer space sensing into a method
ClosedPublic
Actions

Authored by glebius on Feb 10 2025, 10:20 PM.

Details

Reviewers

Group Reviewers

network
transport

Commits

rGa35f24c9055d: sendfile: factor out socket send buffer space sensing into a method

Summary

Move a block of code that works with the socket send buffer from the main
sendfile loop into a separate function. Make it a protocol method, so
that protocols may provide a different one.

While here, provide a long comment explaining why we modify sb_lowat and
why we can't just remove that hack.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Feb 10 2025, 10:20 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 10 2025, 10:20 PM

Herald added subscribers: olce, melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Feb 10 2025, 10:20 PM

Harbormaster completed remote builds in B62340: Diff 150800.Feb 10 2025, 10:20 PM

glebius added a child revision: D48919: sockets: provide protocol method pr_kqfilter.Feb 10 2025, 10:20 PM

markj accepted this revision as: markj.Feb 12 2025, 2:17 PM

markj added inline comments.

sys/sys/protosw.h
118	These annotations assume that the structure is cache line size-aligned (and I presume that that is why you moved the other function pointers around), but AFAICS there is nothing forcing them to be aligned, and in practice they are not aligned.

glebius added inline comments.Feb 12 2025, 6:06 PM

sys/sys/protosw.h
118	This is true. I plan later to rearrange them later. Probably after adding pr_lock(). And possibly use fileops structure pointer as part of protosw. Cause right now we have several file methods that are just translated into protocol methods, with the latter acting as superfluous shim and making list of protosw methods longer.