Paths

Table of Contentst

Differential D48783

nanobsd: Prefer tgt_dir2symlink() to create symlinks
ClosedPublic
Actions

Authored by jlduran on Feb 1 2025, 4:24 AM.

Tags

None

Referenced Files

	F143390962: D48783.diff
	Thu, Jan 29, 8:27 PM

	Unknown Object (File)
	Tue, Jan 27, 7:28 PM

	Unknown Object (File)
	Sun, Jan 25, 1:27 AM

	Unknown Object (File)
	Thu, Jan 22, 12:42 PM

	Unknown Object (File)
	Wed, Jan 21, 8:05 PM

	Unknown Object (File)
	Tue, Jan 20, 1:33 PM

	Unknown Object (File)
	Sun, Jan 18, 5:03 PM

	Unknown Object (File)
	Sun, Jan 18, 2:24 PM

View All 71 Files

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rG5345567935a2: nanobsd: Prefer tgt_dir2symlink() to create symlinks

Summary

Prefer tgt_dir2symlink() to create symlinks, as it has the benefit of
appending the entry to the metalog file.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran requested review of this revision.Feb 1 2025, 4:24 AM

jlduran created this revision.

Harbormaster completed remote builds in B62194: Diff 150326.Feb 1 2025, 4:24 AM

jlduran added a parent revision: D48782: nanobsd: Make tgt_dir2symlink() take a mode.Feb 1 2025, 4:24 AM

jlduran added a child revision: D48784: nanobsd: Set the proper mode for /tmp.

imp accepted this revision.Feb 1 2025, 4:46 AM

This revision is now accepted and ready to land.Feb 1 2025, 4:46 AM

emaste accepted this revision.Feb 1 2025, 12:55 PM

emaste added inline comments.

tools/tools/nanobsd/defaults.sh
552	it's a shame that tgt_dir2symlink is backwards

imp added inline comments.Feb 1 2025, 5:26 PM

tools/tools/nanobsd/defaults.sh
552	It's only used in one place. We can fix it. We can change the name too (maybe `tgt_symlinkdir`) in case we're worried about downstreams using it. I blame ln for seeming backwards all these years for adopting the 'cp' paradigm. I never fail to be confused by this, at least once a year anyway.
552	Or maybe `tgt_ln` :)

jlduran added inline comments.Feb 1 2025, 11:10 PM

tools/tools/nanobsd/defaults.sh
552	You are both right. I'm not going to pretend I have not tried it backwards. I'll sink `tgt_dir2symlink` (move it to `legacy.sh`), and leave it untouched I'll create a new `tgt_ln` function and use that instead

Closed by commit rG5345567935a2: nanobsd: Prefer tgt_dir2symlink() to create symlinks (authored by jlduran). · Explain WhySat, Jan 17, 6:13 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG5345567935a2: nanobsd: Prefer tgt_dir2symlink() to create symlinks.

Revision Contents
Changeset List

Path

Size

tools/

tools/

nanobsd/

2 lines

Diff 169961

tools/tools/nanobsd/defaults.sh

Loading...