nanobsd: Prefer nano_umount to umount
ClosedPublic
Actions

Authored by jlduran on Feb 1 2025, 4:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 12:04 AM

	Unknown Object (File)
	Sat, Sep 5, 12:01 AM

	Unknown Object (File)
	Sat, Sep 5, 12:01 AM

	Unknown Object (File)
	Fri, Sep 4, 4:32 PM

	Unknown Object (File)
	Thu, Sep 3, 12:33 PM

	Unknown Object (File)
	Mon, Aug 31, 11:29 AM

	Unknown Object (File)
	Mon, Aug 31, 2:57 AM

	Unknown Object (File)
	Aug 10 2026, 7:42 PM

View All Files

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rG7106db625ece: nanobsd: Prefer nano_umount to umount

Summary

nano_umount[^1] is a convenience routine used to override issues with
umount(8) without changing the nanobsd.sh source code. There were a few
places where it was not being used.

[^1]: Introduced in 6d12b61a88a6 ("Add a routine for easy workaround any
umount issues w/o hacking nanobsd.sh.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran requested review of this revision.Feb 1 2025, 4:23 AM

jlduran created this revision.

Harbormaster completed remote builds in B62191: Diff 150323.Feb 1 2025, 4:23 AM

jlduran added a child revision: D48781: nanobsd: Add uname/gname to the spec.Feb 1 2025, 4:24 AM

imp accepted this revision.Feb 1 2025, 4:42 AM

This revision is now accepted and ready to land.Feb 1 2025, 4:42 AM

emaste accepted this revision.Feb 1 2025, 12:50 PM

Closed by commit rG7106db625ece: nanobsd: Prefer nano_umount to umount (authored by jlduran). · Explain WhyJan 17 2026, 6:13 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG7106db625ece: nanobsd: Prefer nano_umount to umount.

Revision Contents
Changeset List

Path

Size

tools/

nanobsd/

defaults.sh

6 lines

legacy.sh

2 lines

Diff 169958

View Options

tools/tools/nanobsd/defaults.sh