Differential D48606

rtwn: move to using ieee80211_node_get_txrate()
AcceptedPublic
Actions

Authored by adrian on Jan 23 2025, 2:37 AM.

Tags

Referenced Files

	F110968256: D48606.id151041.diff
	Tue, Feb 25, 2:09 PM

	Unknown Object (File)
	Wed, Feb 12, 6:37 PM

	Unknown Object (File)
	Wed, Feb 12, 6:04 PM

	Unknown Object (File)
	Tue, Feb 11, 2:59 PM

	Unknown Object (File)
	Mon, Feb 10, 2:46 AM

	Unknown Object (File)
	Sun, Feb 9, 12:59 AM

	Unknown Object (File)
	Sun, Feb 9, 12:34 AM

	Unknown Object (File)
	Sun, Feb 9, 12:27 AM

View All 31 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

Migrate the transmit path to use ieee80211_node_get_txrate(), and handle
VHT rates.

Nothing is currently setting VHT rates, but the driver should now
be ready.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62447
Build 59331: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:37 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2025, 2:37 AM

adrian requested review of this revision.Jan 23 2025, 2:37 AM

Harbormaster completed remote builds in B61897: Diff 149735.Jan 23 2025, 2:37 AM

adrian added a parent revision: D48605: net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct.Jan 23 2025, 2:37 AM

adrian added a child revision: D48607: net80211: Implement ieee80211_setup_vht_rates().

adrian added a reviewer: wireless.Jan 23 2025, 3:03 AM

adrian added a project: wireless.

rebsae

Harbormaster completed remote builds in B61957: Diff 149846.Jan 24 2025, 1:51 AM

rebase

Harbormaster completed remote builds in B61984: Diff 149898.Jan 24 2025, 3:31 PM

thj added a subscriber: thj.Jan 24 2025, 4:38 PM

thj added inline comments.

sys/dev/rtwn/if_rtwn_tx.c
172–173	We should remove the (void) cast while we are here

rebase, address changes

Harbormaster completed remote builds in B62050: Diff 150002.Mon, Jan 27, 12:16 AM

bz added a subscriber: bz.Wed, Jan 29, 12:58 AM

bz added inline comments.

sys/dev/rtwn/if_rtwn_tx.c
171	I think you want to leave the 0 out here or you'll only initialize the first element of the struct if I am not mistaken.

update, add TXRATE_HT

Harbormaster completed remote builds in B62113: Diff 150148.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62128: Diff 150163.Thu, Jan 30, 5:16 AM

comments from bz@

Harbormaster completed remote builds in B62447: Diff 151041.Fri, Feb 14, 4:03 PM

adrian marked 2 inline comments as done.Fri, Feb 14, 4:05 PM

adrian added inline comments.

sys/dev/rtwn/if_rtwn_tx.c
171	according to brooks/jhb, { 0 } will zero-init all of the fields (but not the padding, which is fine here); {} is C++ / C23-ism and we're only recently at C17.

seems fine then

This revision is now accepted and ready to land.Sat, Feb 15, 12:34 PM

adrian marked an inline comment as done.Sun, Feb 16, 8:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

49 lines

Diff 151041

sys/dev/rtwn/if_rtwn_tx.c

Loading...