Page MenuHomeFreeBSD
Differential D48156

sound: Do not return an error from chn_notify() if the children list is empty
ClosedPublic
Actions

Authored by christos on Dec 19 2024, 11:20 PM.
Tags
None
Referenced Files
F166455397: D48156.id148266.diff
Thu, Aug 13, 4:33 PM
Unknown Object (File)
Wed, Aug 12, 7:00 AM
Unknown Object (File)
Sat, Aug 8, 9:36 PM
Unknown Object (File)
Sat, Aug 8, 4:19 PM
Unknown Object (File)
Sat, Aug 8, 10:37 AM
Unknown Object (File)
Tue, Aug 4, 4:11 PM
Unknown Object (File)
Mon, Aug 3, 7:55 PM
Unknown Object (File)
Mon, Aug 3, 1:54 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGa86dfa429690: sound: Do not return an error from chn_notify() if the children list is empty
rG164651f16c86: sound: Do not return an error from chn_notify() if the children list is empty
Summary

An empty children list does not mean that there is an error.

Reported by: Florian Walpen <dev@submerge.ch>
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Dec 19 2024, 11:20 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2024, 11:20 PM
christos requested review of this revision.Dec 19 2024, 11:20 PM
Harbormaster completed remote builds in B61274: Diff 148266.Dec 19 2024, 11:20 PM
christos mentioned this in D47917: sound: Allocate vchans on-demand.Dec 19 2024, 11:20 PM
christos added a child revision: D47917: sound: Allocate vchans on-demand.Dec 19 2024, 11:23 PM
dev_submerge.ch accepted this revision.Dec 24 2024, 12:38 PM

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

This revision is now accepted and ready to land.Dec 24 2024, 12:38 PM
christos added a comment.Dec 24 2024, 5:20 PM
In D48156#1098827, @dev_submerge.ch wrote:

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

Thank you for proposing this. :-)

Closed by commit rG164651f16c86: sound: Do not return an error from chn_notify() if the children list is empty (authored by christos). · Explain WhyFeb 25 2025, 11:48 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG164651f16c86: sound: Do not return an error from chn_notify() if the children list is empty.
christos added a commit: rGa86dfa429690: sound: Do not return an error from chn_notify() if the children list is empty.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines

Diff 151457

View Options

sys/dev/sound/pcm/channel.c

Loading...