Paths

Table of Contentst

sound: Cache vchanmode
ClosedPublic
Actions

Authored by christos on Jan 6 2025, 1:45 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG58e17fd3c455: sound: Cache vchanmode
rGb50f53cf872e: sound: Cache vchanmode

Summary

We already cache vchanrate and vchanformat.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Jan 6 2025, 1:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 6 2025, 1:45 PM

christos requested review of this revision.Jan 6 2025, 1:45 PM

Harbormaster completed remote builds in B61518: Diff 148811.Jan 6 2025, 1:45 PM

christos mentioned this in D47918: sound: Simplify vchan_getparentchannel().Jan 6 2025, 1:45 PM

What takes the place of the now-removed locking though?

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Jan 6 2025, 1:58 PM

christos added a child revision: D48336: sound: Handle multiple primary channel cases in vchan sysctls.

In D48335#1102258, @emaste wrote:

What takes the place of the now-removed locking though?

As is the case for vchanrate and vchanformat, the PCM "sleepable lock", aka PCM_ACQUIRE().

dev_submerge.ch accepted this revision.Jan 9 2025, 12:02 PM

This revision is now accepted and ready to land.Jan 9 2025, 12:02 PM

Rebase changes in D48435.

This revision now requires review to proceed.Jan 21 2025, 10:38 AM

Harbormaster completed remote builds in B61854: Diff 149647.Jan 21 2025, 10:38 AM

Revert change. This was meant for another commit and I messed up my git commands.

Harbormaster completed remote builds in B61855: Diff 149648.Jan 21 2025, 10:42 AM

Reapprove, I already accepted this.

This revision is now accepted and ready to land.Jan 25 2025, 1:44 AM

Closed by commit rGb50f53cf872e: sound: Cache vchanmode (authored by christos). · Explain WhyFeb 25 2025, 11:48 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGb50f53cf872e: sound: Cache vchanmode.

christos added a commit: rG58e17fd3c455: sound: Cache vchanmode.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.h

4 lines

vchan.c

11 lines

Diff 151462

View Options

sys/dev/sound/pcm/sound.h