sound: Update comment and channel insertion in vchan_create()
ClosedPublic
Actions

Authored by christos on Feb 12 2025, 12:28 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG127a39c54c2b: sound: Update comment and channel insertion in vchan_create()
rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create()

Summary

The comment and rationale behind choosing CHN_INSERT_SORT_DESCEND()
instead of CHN_INSERT_SORT_ASCEND() are no longer relevant as of FILLME
("sound: Allocate vchans on-demand").

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Feb 12 2025, 12:28 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 12:28 PM

christos requested review of this revision.Feb 12 2025, 12:28 PM

Harbormaster completed remote builds in B62391: Diff 150897.Feb 12 2025, 12:28 PM

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Feb 12 2025, 12:28 PM

christos added a parent revision: D48961: sound: Fix vchanrate and vchanformat.

Typo.

Harbormaster completed remote builds in B62392: Diff 150898.Feb 12 2025, 12:29 PM

christos added a child revision: D48966: sound: Call chn_kill() in chn_init() failure.Feb 12 2025, 4:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2025, 11:49 AM

Closed by commit rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create() (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create().

christos removed a parent revision: D48961: sound: Fix vchanrate and vchanformat.Feb 25 2025, 12:10 PM

christos added a commit: rG127a39c54c2b: sound: Update comment and channel insertion in vchan_create().Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

7 lines

Diff 151471

View Options

sound: Update comment and channel insertion in vchan_create()ClosedPublicActions