Page MenuHomeFreeBSD
Differential D48962

sound: Update comment and channel insertion in vchan_create()
ClosedPublic
Actions

Authored by christos on Feb 12 2025, 12:28 PM.
Tags
None
Referenced Files
F171101102: D48962.id150898.diff
Tue, Sep 8, 5:13 PM
Unknown Object (File)
Sun, Sep 6, 1:31 PM
Unknown Object (File)
Sat, Sep 5, 8:31 AM
Unknown Object (File)
Fri, Sep 4, 1:27 PM
Unknown Object (File)
Wed, Sep 2, 1:38 PM
Unknown Object (File)
Tue, Sep 1, 12:09 PM
Unknown Object (File)
Mon, Aug 31, 1:53 PM
Unknown Object (File)
Fri, Aug 28, 4:40 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG127a39c54c2b: sound: Update comment and channel insertion in vchan_create()
rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create()
Summary

The comment and rationale behind choosing CHN_INSERT_SORT_DESCEND()
instead of CHN_INSERT_SORT_ASCEND() are no longer relevant as of FILLME
("sound: Allocate vchans on-demand").

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Feb 12 2025, 12:28 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 12:28 PM
christos requested review of this revision.Feb 12 2025, 12:28 PM
Harbormaster completed remote builds in B62391: Diff 150897.Feb 12 2025, 12:28 PM
christos added a parent revision: D47917: sound: Allocate vchans on-demand.Feb 12 2025, 12:28 PM
christos added a parent revision: D48961: sound: Fix vchanrate and vchanformat.
christos updated this revision to Diff 150898.Feb 12 2025, 12:29 PM

Typo.

Harbormaster completed remote builds in B62392: Diff 150898.Feb 12 2025, 12:29 PM
christos added a child revision: D48966: sound: Call chn_kill() in chn_init() failure.Feb 12 2025, 4:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2025, 11:49 AM
Closed by commit rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create() (authored by christos). · Explain Why
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG2868776c9c6f: sound: Update comment and channel insertion in vchan_create().
christos removed a parent revision: D48961: sound: Fix vchanrate and vchanformat.Feb 25 2025, 12:10 PM
christos added a commit: rG127a39c54c2b: sound: Update comment and channel insertion in vchan_create().Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
7 lines

Diff 151471

View Options

sys/dev/sound/pcm/vchan.c

Loading...