sound: Do not return an error from chn_notify() if the children list is empty
AcceptedPublic
Actions

Authored by christos on Thu, Dec 19, 11:20 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

An empty children list does not mean that there is an error.

Reported by: Florian Walpen <dev@submerge.ch>
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61274
Build 58158: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Dec 19, 11:20 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Dec 19, 11:20 PM

christos requested review of this revision.Thu, Dec 19, 11:20 PM

Harbormaster completed remote builds in B61274: Diff 148266.Thu, Dec 19, 11:20 PM

christos mentioned this in D47917: sound: Allocate vchans on-demand.Thu, Dec 19, 11:20 PM

christos added a child revision: D47917: sound: Allocate vchans on-demand.Thu, Dec 19, 11:23 PM

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

This revision is now accepted and ready to land.Tue, Dec 24, 12:38 PM

In D48156#1098827, @dev_submerge.ch wrote:

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

Thank you for proposing this. :-)

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

2 lines

Diff 148266

View Options

sys/dev/sound/pcm/channel.c

sound: Do not return an error from chn_notify() if the children list is emptyAcceptedPublicActions