Page MenuHomeFreeBSD
Differential D48012

sound: Return if the new speed/format is the same as the current one
Needs ReviewPublic
Actions

Authored by christos on Dec 9 2024, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 11:50 AM
Unknown Object (File)
Wed, Jan 8, 8:57 PM
Unknown Object (File)
Dec 17 2024, 4:44 PM
Unknown Object (File)
Dec 15 2024, 9:53 PM
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

This gives us a slight performance boost since we do not have to go
through the driver functions.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61682
Build 58566: arc lint + arc unit

Event Timeline

christos created this revision.Dec 9 2024, 10:58 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 9 2024, 10:58 PM
christos requested review of this revision.Dec 9 2024, 10:58 PM
Harbormaster completed remote builds in B61060: Diff 147758.Dec 9 2024, 10:58 PM
christos added a parent revision: D48011: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat().Dec 9 2024, 10:58 PM
emaste accepted this revision.Dec 10 2024, 2:02 AM

This looks OK.

This revision is now accepted and ready to land.Dec 10 2024, 2:02 AM
dev_submerge.ch accepted this revision.Dec 13 2024, 12:52 AM
christos edited the summary of this revision. (Show Details)Sun, Jan 12, 1:08 AM
christos updated this revision to Diff 149145.Sun, Jan 12, 1:08 AM

Do the same for chn_setparam().

This revision now requires review to proceed.Sun, Jan 12, 1:08 AM
Harbormaster completed remote builds in B61681: Diff 149145.Sun, Jan 12, 1:08 AM
christos updated this revision to Diff 149146.Sun, Jan 12, 1:17 AM

Revert change, bad idea.

Harbormaster completed remote builds in B61682: Diff 149146.Sun, Jan 12, 1:17 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
6 lines

Diff 149146

View Options

sys/dev/sound/pcm/channel.c

Loading...