Page MenuHomeFreeBSD
Differential D48012

sound: Return if the new speed/format is the same as the current one
ClosedPublic
Actions

Authored by christos on Dec 9 2024, 10:58 PM.
Tags
None
Referenced Files
F172977533: D48012.id149145.diff
Tue, Sep 22, 2:20 PM
F172941402: D48012.diff
Tue, Sep 22, 6:52 AM
F172879353: D48012.id151467.diff
Mon, Sep 21, 7:31 PM
Unknown Object (File)
Sat, Sep 19, 9:36 PM
Unknown Object (File)
Fri, Sep 18, 9:50 AM
Unknown Object (File)
Wed, Sep 16, 11:41 AM
Unknown Object (File)
Thu, Sep 10, 10:25 PM
Unknown Object (File)
Thu, Sep 10, 4:54 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG21e0d2aa35bf: sound: Return if the new speed/format is the same as the current one
rG40616b7e41ff: sound: Return if the new speed/format is the same as the current one
Summary

This gives us a slight performance boost since we do not have to go
through the driver functions.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61682
Build 58566: arc lint + arc unit

Event Timeline

christos created this revision.Dec 9 2024, 10:58 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 9 2024, 10:58 PM
christos requested review of this revision.Dec 9 2024, 10:58 PM
Harbormaster completed remote builds in B61060: Diff 147758.Dec 9 2024, 10:58 PM
christos added a parent revision: D48011: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat().Dec 9 2024, 10:58 PM
emaste accepted this revision.Dec 10 2024, 2:02 AM

This looks OK.

This revision is now accepted and ready to land.Dec 10 2024, 2:02 AM
dev_submerge.ch accepted this revision.Dec 13 2024, 12:52 AM
christos edited the summary of this revision. (Show Details)Jan 12 2025, 1:08 AM
christos updated this revision to Diff 149145.Jan 12 2025, 1:08 AM

Do the same for chn_setparam().

This revision now requires review to proceed.Jan 12 2025, 1:08 AM
Harbormaster completed remote builds in B61681: Diff 149145.Jan 12 2025, 1:08 AM
christos updated this revision to Diff 149146.Jan 12 2025, 1:17 AM

Revert change, bad idea.

Harbormaster completed remote builds in B61682: Diff 149146.Jan 12 2025, 1:17 AM
christos added a comment.Jan 30 2025, 3:36 PM

@dev_submerge.ch @emaste Can you re-accept this patch?

dev_submerge.ch accepted this revision.Feb 2 2025, 3:56 PM
This revision is now accepted and ready to land.Feb 2 2025, 3:56 PM
Closed by commit rG40616b7e41ff: sound: Return if the new speed/format is the same as the current one (authored by christos). · Explain WhyFeb 25 2025, 11:48 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG40616b7e41ff: sound: Return if the new speed/format is the same as the current one.
christos added a commit: rG21e0d2aa35bf: sound: Return if the new speed/format is the same as the current one.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
6 lines

Diff 149146

View Options

sys/dev/sound/pcm/channel.c

Loading...