inpcb: Remove some unused parameters in internal hash lookup functions
ClosedPublic
Actions

Authored by markj on Nov 1 2024, 1:41 PM.

Details

Reviewers

Group Reviewers

Commits

rG0629203c5392: inpcb: Remove some unused parameters in internal hash lookup functions
rG21d7ac8c79a3: inpcb: Remove some unused parameters in internal hash lookup functions

Summary

in_pcblookup_hash_wild_* looks up unconnected inpcbs, so there is no
point in passing the foreign address and port, and indeed those
parameters are not used. So, remove them.

No functional change intended.

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 1 2024, 1:41 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptNov 1 2024, 1:41 PM

markj requested review of this revision.Nov 1 2024, 1:41 PM

Harbormaster completed remote builds in B60327: Diff 145833.Nov 1 2024, 1:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2024, 2:26 PM

Closed by commit rG21d7ac8c79a3: inpcb: Remove some unused parameters in internal hash lookup functions (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG21d7ac8c79a3: inpcb: Remove some unused parameters in internal hash lookup functions.

markj added a commit: rG0629203c5392: inpcb: Remove some unused parameters in internal hash lookup functions.Feb 21 2025, 1:57 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

17 lines

netinet6/

in6_pcb.c

14 lines

Diff 146173

View Options

sys/netinet/in_pcb.c