ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2
ClosedPublic
Actions

Authored by cperciva on Oct 22 2024, 2:50 PM.

Details

Reviewers

imp
jhb
alisaidi_amazon.com

Commits

rG28b881840df7: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2
rG5fa51c3653b1: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2
rG2f3f867ac6dd: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2

Summary

AWS Graviton [1234] systems have a bug in their ACPI where they mark
the PL061's GPIO pins as needing to be configured in PullUp mode (in
fact the PL061 has no pullup/pulldown resistors); this flag needs to
be removed in order for _AEI objects to be handled on these systems.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Oct 22 2024, 2:50 PM

Herald added subscribers: jrtc27, loos, imp. · View Herald TranscriptOct 22 2024, 2:50 PM

cperciva requested review of this revision.Oct 22 2024, 2:50 PM

Harbormaster completed remote builds in B60150: Diff 145350.Oct 22 2024, 2:50 PM

This patch doesn't actually use the flag but it will be handled in forthcoming changes to sys/dev/gpio/acpi_gpiobus.c as part of adding _AEI object support.

cperciva mentioned this in D47253: GPIO: Add ACPI _AEI support.Oct 22 2024, 7:11 PM

Ali isn't able to get into Phabricator right now (possibly due to email issues between FreeBSD.org and Amazon.com) but out of band he said that this looked good to him.

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Oct 26, 2:35 AM

Closed by commit rG2f3f867ac6dd: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG2f3f867ac6dd: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2.

cperciva added a commit: rG5fa51c3653b1: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2.Sun, Nov 3, 4:03 PM

cperciva added a commit: rG28b881840df7: ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2.Sun, Nov 3, 4:17 PM