Page MenuHomeFreeBSD

mbuf: Add M_WRITABLE_EXTPG
AcceptedPublic

Authored by jhb on Sep 25 2024, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 1:30 PM
Unknown Object (File)
Wed, Jul 1, 9:02 AM
Unknown Object (File)
Tue, Jun 30, 2:22 PM
Unknown Object (File)
Mon, Jun 29, 5:18 AM
Unknown Object (File)
Thu, Jun 25, 9:37 AM
Unknown Object (File)
Sun, Jun 21, 3:18 PM
Unknown Object (File)
Thu, Jun 18, 10:42 PM
Unknown Object (File)
May 8 2026, 8:53 PM
Subscribers

Details

Reviewers
gallatin
kp
Summary

This can be used instead of M_WRITABLE where the calling code is
prepared to handle writing to M_EXTPG mbufs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59597
Build 56484: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 25 2024, 3:13 PM

I'm confused.. if we are marking non-writable M_EXTPG mufs as M_RDONLY, why can't we simply remove the M_EXTPG check from M_WRITABLE? Why do we need a new macro?

I'm confused.. if we are marking non-writable M_EXTPG mufs as M_RDONLY, why can't we simply remove the M_EXTPG check from M_WRITABLE? Why do we need a new macro?

Because there are many places that call M_WRITABLE in the tree and if it succeeds expect to directly use mtod() to get a writable pointer to the data payload (possibly after using m_pullup which panics if called on an M_EXTPG mbuf). m_copyback() is explicitly aware of M_EXTPG mbufs and handles them correctly, so the new macro works fine the assertion there.

This revision is now accepted and ready to land.Sep 26 2024, 2:37 PM