pfctl: improve bitmask printing
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:35 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGe044f67a66c8: pfctl: improve bitmask printing

Summary

In some cases the netmask gets set to a full 128 bit mask even if no
address family is selected; don't print the v6 mask if it's a v4 address.

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, f6d7b41f07
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59372
Build 56259: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:35 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 7 2024, 9:35 AM

kp requested review of this revision.Sep 7 2024, 9:35 AM

kp added a parent revision: D46583: pf: fix potential memory leaks in pf_create_state().

Harbormaster completed remote builds in B59372: Diff 143080.Sep 7 2024, 9:35 AM

kp added a child revision: D46585: pf: print rule number in debug output.Sep 7 2024, 9:35 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2024, 8:21 PM

Closed by commit rGe044f67a66c8: pfctl: improve bitmask printing (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGe044f67a66c8: pfctl: improve bitmask printing.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

pf_print_state.c

2 lines

Diff 143080

View Options

sbin/pfctl/pf_print_state.c

pfctl: improve bitmask printingClosedPublicActions