Page MenuHomeFreeBSD
Differential D46259

netinet: Add a sysctl to allow disabling connections to INADDR_ANY
ClosedPublic
Actions

Authored by markj on Aug 9 2024, 11:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 5:22 AM
Unknown Object (File)
Sun, Dec 8, 9:37 PM
Unknown Object (File)
Nov 6 2024, 2:20 PM
Unknown Object (File)
Nov 6 2024, 12:52 PM
Unknown Object (File)
Nov 6 2024, 11:37 AM
Unknown Object (File)
Nov 6 2024, 11:19 AM
Unknown Object (File)
Nov 6 2024, 9:21 AM
Unknown Object (File)
Nov 5 2024, 3:21 PM
View All 26 Files
Subscribers
ae
glebius
imp
jamie_catflap.org
melifaro
zlei

Details

Reviewers
None
Group Reviewers
network
Commits
rG8ae58e0edbfb: netinet: Add a sysctl to allow disabling connections to INADDR_ANY
rG417b35a97b76: netinet: Add a sysctl to allow disabling connections to INADDR_ANY
Summary

See the discussion in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280705 for context.

PR: 280705

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Aug 9 2024, 11:47 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptAug 9 2024, 11:47 PM
markj requested review of this revision.Aug 9 2024, 11:47 PM
Harbormaster completed remote builds in B58981: Diff 141964.Aug 9 2024, 11:47 PM
jamie_catflap.org added a subscriber: jamie_catflap.org.Aug 10 2024, 2:23 PM
zlei added a subscriber: zlei.Aug 12 2024, 9:25 AM
zlei added inline comments.
sys/netinet/in_pcb.c
237

Maybe default to 0 to disable this feature ? The behavior can be easily reverted if required, if it is indeed useful to some users.

markj added inline comments.Aug 12 2024, 2:35 PM
sys/netinet/in_pcb.c
237

We should, yes, but right now we have no idea what breaks. My thinking is to start by making the behaviour configurable, so that developers can experiment more easily.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2024, 9:35 PM
Closed by commit rG417b35a97b76: netinet: Add a sysctl to allow disabling connections to INADDR_ANY (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG417b35a97b76: netinet: Add a sysctl to allow disabling connections to INADDR_ANY.
markj added a commit: rG8ae58e0edbfb: netinet: Add a sysctl to allow disabling connections to INADDR_ANY.Sep 3 2024, 2:55 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
8 lines
netinet6/
12 lines

Diff 142277

View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet6/in6_pcb.c

Loading...