Add new switches to service(8): enable, disable, rcopts and rcdelete

[allanjude]

Summary

The patch adds new switches to service(8). This is what can be done with it:

$ service sshd rcopts
Available rc.conf options for sshd:

\#
\# sshd_enable (bool): Set to "NO" by default.
\# Set it to "YES" to enable sshd
\# sshd_rsa1_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable rsa1 host key
\# sshd_rsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable rsa host key
\# sshd_dsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable dsa host key
\# sshd_ecdsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable ecdsa host key

$ service sshd disable stop
sshd disabled in /etc/rc.conf
Stopping sshd.
Waiting for PIDS: 1728.

$ service sshd rcdelete
sshd deleted in /etc/rc.conf

$ service sshd enable
sshd enabled in /etc/rc.conf

$ service sshd start
Performing sanity check on sshd configuration.
Starting sshd.

[bapt]

It will be nice not to touch rc.conf but rather use /etc/rc.conf.d

[lme]

I'm a bit biased on that.
One big plus for FreeBSD is that you have all service config settings in a single /etc/rc.conf file.
On the other hand there are tools like puppet and ansible which can add separate files in a /etc/rc.conf.d/ directory.
I will see how to handle this.

[lme]

Here's an updated patch.

It introduces the -s flag so that instead of /etc/rc.conf /etc/rc.conf.d/$script is used.

[bapt]

imho the default should be to not touch /etc/rc.conf and always use rc.conf.d

[bdrewery]

I strictly use rc.conf.local on my systems. The rc.conf is shared among all through a config management system. If I were to disable a service on 1 I expect it to use rc.conf.local (or at least not rc.conf) because my config management will just replace rc.conf back to the global one anyhow.

[eadler]

does bsdconfig(8) not handle this use case?

[lme]

AFAIK it cannot. At least at the time of writing the patch.

[allanjude]

I have an enhanced version of this patch for review

[allanjude]

Reimplemented some of lme@'s changes to use newer features of sysrc

Added some new features of my own (-s to get the status of all enabled services)

Depends on D3551 for sysrc -s support

[allanjude]

Update with feedback from Pierre Pronchery (netbsd)

and a run through http://www.shellcheck.net/

[lme]

I'm fine with it.

But I don't think that it is a good idea to add new functionality and change `` to $() in one step.

[roberto]

I'm still a bit worried about the duplication with regard to sysrc(8)…

[lme]

It's not really duplicated. I find it really useful to just run "service apache24 enable start" instead of running "sysrc apache24_enable=yes; service apache24 start"

[allanjude]

Updated to use /etc/rc.conf unless /etc/rc.conf.d exists of CONFFILE is set

[allanjude]

Sync

[allanjude]

Integrate D5846

Depends on D5846

[allanjude]

Fix the variable for the filename

[lme]

Could someone commit this?

[lme]

A new version of this patch is created as https://reviews.freebsd.org/D17113