Details

Reviewers

dteske
eadler
lme
delphij
marcel
bapt
roberto

Group Reviewers

manpages

Summary

The patch adds new switches to service(8). This is what can be done with it:

$ service sshd rcopts
Available rc.conf options for sshd:

\#
\# sshd_enable (bool): Set to "NO" by default.
\# Set it to "YES" to enable sshd
\# sshd_rsa1_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable rsa1 host key
\# sshd_rsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable rsa host key
\# sshd_dsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable dsa host key
\# sshd_ecdsa_enable (bool): Set to "YES" by default.
\# Seit it to "NO" to disable ecdsa host key

$ service sshd disable stop
sshd disabled in /etc/rc.conf
Stopping sshd.
Waiting for PIDS: 1728.

$ service sshd rcdelete
sshd deleted in /etc/rc.conf

$ service sshd enable
sshd enabled in /etc/rc.conf

$ service sshd start
Performing sanity check on sshd configuration.
Starting sshd.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3435
Build 3474: arc lint + arc unit

Event Timeline

lme updated this revision to Diff 773.Jul 19 2014, 3:52 PM

lme retitled this revision from to Add new switches to service(8): enable, disable, rcopts and rcdelete.

lme updated this object.

lme edited the test plan for this revision. (Show Details)

lme added reviewers: delphij, eadler.

lme added a parent revision: D452: Add new commands to rc(8): describe and extracommands.Jul 19 2014, 3:58 PM

lme updated this object.

lme edited the test plan for this revision. (Show Details)

lme updated this object.Jul 19 2014, 4:00 PM

lme edited the test plan for this revision. (Show Details)

lme updated this object.Jul 19 2014, 4:07 PM

It will be nice not to touch rc.conf but rather use /etc/rc.conf.d

I'm a bit biased on that.
One big plus for FreeBSD is that you have all service config settings in a single /etc/rc.conf file.
On the other hand there are tools like puppet and ansible which can add separate files in a /etc/rc.conf.d/ directory.
I will see how to handle this.

Here's an updated patch.

It introduces the -s flag so that instead of /etc/rc.conf /etc/rc.conf.d/$script is used.

imho the default should be to not touch /etc/rc.conf and always use rc.conf.d

This revision now requires changes to proceed.Jul 22 2014, 3:20 PM

I strictly use rc.conf.local on my systems. The rc.conf is shared among all through a config management system. If I were to disable a service on 1 I expect it to use rc.conf.local (or at least not rc.conf) because my config management will just replace rc.conf back to the global one anyhow.

does bsdconfig(8) not handle this use case?

AFAIK it cannot. At least at the time of writing the patch.

allanjude edited edge metadata.Aug 27 2015, 9:35 PM

allanjude added a subscriber: allanjude.

I have an enhanced version of this patch for review

Reimplemented some of lme@'s changes to use newer features of sysrc

Added some new features of my own (-s to get the status of all enabled services)

Depends on D3551 for sysrc -s support

Herald added a reviewer: manpages. · View Herald TranscriptSep 9 2015, 5:16 AM

Herald added a subscriber: imp. · View Herald Transcript

allanjude added reviewers: dteske, marcel.Sep 9 2015, 5:20 PM

Update with feedback from Pierre Pronchery (netbsd)

and a run through http://www.shellcheck.net/

Herald edited edge metadata. · View Herald TranscriptSep 10 2015, 12:28 AM

I'm fine with it.

But I don't think that it is a good idea to add new functionality and change `` to $() in one step.

I'm still a bit worried about the duplication with regard to sysrc(8)…

It's not really duplicated. I find it really useful to just run "service apache24 enable start" instead of running "sysrc apache24_enable=yes; service apache24 start"