Page MenuHomeFreeBSD
Differential D45092

ifconfig(8): wordsmith -G and -g descriptions
ClosedPublic
Actions

Authored by pauamma_gundo.com on May 5 2024, 12:02 AM.
Tags
None
Referenced Files
F106197788: D45092.diff
Fri, Dec 27, 12:27 AM
Unknown Object (File)
Nov 4 2024, 3:48 AM
Unknown Object (File)
Oct 11 2024, 1:14 AM
Unknown Object (File)
Oct 10 2024, 10:12 PM
Unknown Object (File)
Sep 16 2024, 7:46 PM
Unknown Object (File)
Sep 6 2024, 4:45 AM
Unknown Object (File)
Sep 3 2024, 9:29 AM
Unknown Object (File)
Sep 3 2024, 9:29 AM
View All 36 Files
Subscribers
concussious.bugzilla_runbox.com
freebsd_igalic.co
imp

Details

Reviewers
concussious.bugzilla_runbox.com
freebsd_igalic.co
allanjude
bjk
Group Reviewers
manpages
Doc Committers
Commits
rG170a7f2ec185: ifconfig(8): wordsmith -G and -g descriptions
rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions
Summary

Remove spurious ".Ar groupname".
Add missing full stops.
While there, tweak word order for better grammar.

MFC after: 3 days

Test Plan

man and check output.

mandoc -T lint and check the changed area has no warnings.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58093
Build 54981: arc lint + arc unit

Event Timeline

pauamma_gundo.com created this revision.May 5 2024, 12:02 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 5 2024, 12:02 AM
pauamma_gundo.com requested review of this revision.May 5 2024, 12:02 AM
Harbormaster completed remote builds in B57586: Diff 138144.May 5 2024, 12:03 AM
concussious.bugzilla_runbox.com accepted this revision as: concussious.bugzilla_runbox.com.May 5 2024, 12:43 AM
concussious.bugzilla_runbox.com added a subscriber: concussious.bugzilla_runbox.com.
concussious.bugzilla_runbox.com added inline comments.
sbin/ifconfig/ifconfig.8
4
This revision is now accepted and ready to land.May 5 2024, 12:43 AM
pauamma_gundo.com added a reviewer: Doc Committers.May 12 2024, 5:54 PM
pauamma_gundo.com retitled this revision from Wordsmith -G and -g descriptions to ifconfig(8): wordsmith -G and -g descriptions.May 13 2024, 12:00 PM
freebsd_igalic.co accepted this revision.EditedMay 13 2024, 12:01 PM
freebsd_igalic.co added a subscriber: freebsd_igalic.co.

👍

pauamma_gundo.com added reviewers: allanjude, bjk.May 29 2024, 9:34 PM
allanjude accepted this revision as: allanjude.Jun 6 2024, 4:04 PM

Looks good, just the SPDX and the date need fixing.

sbin/ifconfig/ifconfig.8
31

The date will need to be bumped as well

pauamma_gundo.com updated this revision to Diff 139598.Jun 6 2024, 8:25 PM
  • Change per concussious' request (which I completely missed)
  • s/previous/earlier/ (instance I missed)
  • bump .Dd
This revision now requires review to proceed.Jun 6 2024, 8:25 PM
Harbormaster completed remote builds in B58093: Diff 139598.Jun 6 2024, 8:25 PM
pauamma_gundo.com marked 2 inline comments as done.Jun 6 2024, 8:29 PM

Thanks to @imp for reminding me in IRC of the change request I missed.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2024, 9:52 PM
Closed by commit rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions (authored by pauamma_gundo.com, committed by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions.
imp added a commit: rG170a7f2ec185: ifconfig(8): wordsmith -G and -g descriptions.Jun 12 2024, 9:55 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
14 lines

Diff 139598

View Options

sbin/ifconfig/ifconfig.8

Loading...