Page MenuHomeFreeBSD
Differential D45092

ifconfig(8): wordsmith -G and -g descriptions
ClosedPublic
Actions

Authored by pauamma_gundo.com on May 5 2024, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 7, 4:33 AM
Unknown Object (File)
Mon, Jun 3, 1:38 AM
Unknown Object (File)
May 13 2024, 1:11 AM
Unknown Object (File)
May 8 2024, 4:58 AM
Unknown Object (File)
May 8 2024, 4:45 AM
Unknown Object (File)
May 8 2024, 1:20 AM
Unknown Object (File)
May 7 2024, 7:30 PM
Unknown Object (File)
May 5 2024, 3:40 AM
Subscribers
concussious.bugzilla_runbox.com
freebsd_igalic.co
imp

Details

Reviewers
concussious.bugzilla_runbox.com
freebsd_igalic.co
allanjude
bjk
Group Reviewers
manpages
Doc Committers
Commits
rG170a7f2ec185: ifconfig(8): wordsmith -G and -g descriptions
rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions
Summary

Remove spurious ".Ar groupname".
Add missing full stops.
While there, tweak word order for better grammar.

MFC after: 3 days

Test Plan

man and check output.

mandoc -T lint and check the changed area has no warnings.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57586
Build 54474: arc lint + arc unit

Event Timeline

pauamma_gundo.com created this revision.May 5 2024, 12:02 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 5 2024, 12:02 AM
pauamma_gundo.com requested review of this revision.May 5 2024, 12:02 AM
Harbormaster completed remote builds in B57586: Diff 138144.May 5 2024, 12:03 AM
concussious.bugzilla_runbox.com accepted this revision as: concussious.bugzilla_runbox.com.May 5 2024, 12:43 AM
concussious.bugzilla_runbox.com added a subscriber: concussious.bugzilla_runbox.com.
concussious.bugzilla_runbox.com added inline comments.
sbin/ifconfig/ifconfig.8
1
This revision is now accepted and ready to land.May 5 2024, 12:43 AM
pauamma_gundo.com added a reviewer: Doc Committers.May 12 2024, 5:54 PM
pauamma_gundo.com retitled this revision from Wordsmith -G and -g descriptions to ifconfig(8): wordsmith -G and -g descriptions.May 13 2024, 12:00 PM
freebsd_igalic.co accepted this revision.EditedMay 13 2024, 12:01 PM
freebsd_igalic.co added a subscriber: freebsd_igalic.co.

👍

pauamma_gundo.com added reviewers: allanjude, bjk.Wed, May 29, 9:34 PM
allanjude accepted this revision as: allanjude.Thu, Jun 6, 4:04 PM

Looks good, just the SPDX and the date need fixing.

sbin/ifconfig/ifconfig.8
28

The date will need to be bumped as well

pauamma_gundo.com updated this revision to Diff 139598.Thu, Jun 6, 8:25 PM
  • Change per concussious' request (which I completely missed)
  • s/previous/earlier/ (instance I missed)
  • bump .Dd
This revision now requires review to proceed.Thu, Jun 6, 8:25 PM
Harbormaster completed remote builds in B58093: Diff 139598.Thu, Jun 6, 8:25 PM
pauamma_gundo.com marked 2 inline comments as done.Thu, Jun 6, 8:29 PM

Thanks to @imp for reminding me in IRC of the change request I missed.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jun 6, 9:52 PM
Closed by commit rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions (authored by pauamma_gundo.com, committed by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG21faf821a304: ifconfig(8): wordsmith -G and -g descriptions.
imp added a commit: rG170a7f2ec185: ifconfig(8): wordsmith -G and -g descriptions.Wed, Jun 12, 9:55 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
9 lines

Diff 138144

View Options

sbin/ifconfig/ifconfig.8

Loading...