Page MenuHomeFreeBSD
Differential D44934

arm64/vmm: Handle VM_EXITCODE_SUSPENDED
ClosedPublic
Actions

Authored by markj on Apr 24 2024, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 2:05 PM
Unknown Object (File)
Thu, Feb 27, 7:36 AM
Unknown Object (File)
Thu, Feb 27, 5:26 AM
Unknown Object (File)
Wed, Feb 26, 10:19 AM
Unknown Object (File)
Tue, Feb 25, 7:18 PM
Unknown Object (File)
Feb 10 2025, 1:28 PM
Unknown Object (File)
Feb 8 2025, 9:33 AM
Unknown Object (File)
Jan 31 2025, 8:17 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
corvink
jhb
andrew
manu
Commits
rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED
Summary

This is required for bhyve reboot to work. In particular, unless we
suspend vcpu threads here, vm_reinit() will fail with EBUSY.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Apr 24 2024, 10:29 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 24 2024, 10:29 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
markj requested review of this revision.Apr 24 2024, 10:29 PM
Harbormaster completed remote builds in B57336: Diff 137635.Apr 24 2024, 10:29 PM
markj added a parent revision: D44933: vmrun.sh: Add arm64 support.Apr 24 2024, 10:29 PM
corvink added inline comments.Apr 26 2024, 7:11 AM
sys/arm64/vmm/vmm.c
1735

Where's the rendezvous handler called?

Can we reuse the function from sys/amd64/vmm/vmm.c? If we can't share code, it might be a good idea to add a comment on top of the function like Copied from sys/amd64/vmm/vmm.c. Keep it in sync!.

markj added inline comments.Apr 26 2024, 1:19 PM
sys/arm64/vmm/vmm.c
1735

arm64 doesn't implement a rendezvous operation.

In parallel I am working on merging this code with amd64 into sys/dev/vmm, so for now it is enough to try to minimize differences that appear with diff(1).

corvink accepted this revision.Apr 29 2024, 6:25 AM
This revision is now accepted and ready to land.Apr 29 2024, 6:25 AM
andrew accepted this revision.Apr 29 2024, 9:04 AM
Closed by commit rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED (authored by markj). · Explain WhyApr 29 2024, 2:22 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
53 lines

Diff 137844

View Options

sys/arm64/vmm/vmm.c

Show All 19 Lines
.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL .\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS .\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.Dd June 16, 2023 .Dd November 12, 2024
.Dt ROUTE 8 .Dt ROUTE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm route .Nm route
.Nd manually manipulate the routing tables .Nd manually manipulate the routing tables
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl j Ar jail .Op Fl j Ar jail
▲ Show 20 Lines • Show All 510 Lines • ▼ Show 20 Lines
.Xr loader.conf 5 , .Xr loader.conf 5 ,
.Xr arp 8 , .Xr arp 8 ,
.Xr routed 8 .Xr routed 8
.Sh HISTORY .Sh HISTORY
The The
.Nm .Nm
utility appeared in utility appeared in
.Bx 4.2 . .Bx 4.2 .
.Sh BUGS
The first paragraph may have slightly exaggerated
.Xr routed 8 Ns 's
abilities.
.Pp
Currently, routes with the
.Dv RTF_BLACKHOLE
flag set need to have the gateway set to an instance of the
.Xr lo 4
driver, using the
.Fl iface
option, for the flag to have any effect; unless IP fast forwarding
is enabled, in which case the meaning of the flag will always
be honored.