Page MenuHomeFreeBSD
Differential D44934

arm64/vmm: Handle VM_EXITCODE_SUSPENDED
ClosedPublic
Actions

Authored by markj on Wed, Apr 24, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 7:43 AM
Unknown Object (File)
Mon, Apr 29, 2:22 PM
Unknown Object (File)
Sat, Apr 27, 7:43 PM
Unknown Object (File)
Sat, Apr 27, 5:12 AM
Unknown Object (File)
Fri, Apr 26, 7:30 PM
Unknown Object (File)
Fri, Apr 26, 7:29 PM
Unknown Object (File)
Fri, Apr 26, 3:53 PM
Subscribers
emaste
imp

Details

Reviewers
corvink
jhb
andrew
manu
Commits
rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED
Summary

This is required for bhyve reboot to work. In particular, unless we
suspend vcpu threads here, vm_reinit() will fail with EBUSY.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Wed, Apr 24, 10:29 PM
Herald added a reviewer: manu. · View Herald TranscriptWed, Apr 24, 10:29 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
markj requested review of this revision.Wed, Apr 24, 10:29 PM
Harbormaster completed remote builds in B57336: Diff 137635.Wed, Apr 24, 10:29 PM
markj added a parent revision: D44933: vmrun.sh: Add arm64 support.Wed, Apr 24, 10:29 PM
corvink added inline comments.Fri, Apr 26, 7:11 AM
sys/arm64/vmm/vmm.c
1735

Where's the rendezvous handler called?

Can we reuse the function from sys/amd64/vmm/vmm.c? If we can't share code, it might be a good idea to add a comment on top of the function like Copied from sys/amd64/vmm/vmm.c. Keep it in sync!.

markj added inline comments.Fri, Apr 26, 1:19 PM
sys/arm64/vmm/vmm.c
1735

arm64 doesn't implement a rendezvous operation.

In parallel I am working on merging this code with amd64 into sys/dev/vmm, so for now it is enough to try to minimize differences that appear with diff(1).

corvink accepted this revision.Mon, Apr 29, 6:25 AM
This revision is now accepted and ready to land.Mon, Apr 29, 6:25 AM
andrew accepted this revision.Mon, Apr 29, 9:04 AM
Closed by commit rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED (authored by markj). · Explain WhyMon, Apr 29, 2:22 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG1ee7a8fa58c3: arm64/vmm: Handle VM_EXITCODE_SUSPENDED.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
53 lines

Diff 137844

View Options

sys/arm64/vmm/vmm.c

Loading...