Page MenuHomeFreeBSD

tcp: fix RTO ssthresh for non-6675 pipe calculation
ClosedPublic

Authored by rscheff on Feb 14 2024, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 5:02 AM
Unknown Object (File)
Wed, Mar 12, 9:13 PM
Unknown Object (File)
Feb 6 2025, 9:32 PM
Unknown Object (File)
Jan 27 2025, 10:44 PM
Unknown Object (File)
Jan 26 2025, 11:37 PM
Unknown Object (File)
Nov 21 2024, 11:13 AM
Unknown Object (File)
Nov 18 2024, 1:40 PM
Unknown Object (File)
Nov 18 2024, 11:59 AM

Details

Summary

D43768 has two oversights, affecting the non-default pipe calculation
when RFC6675 (net.inet.tcp.sack.revised) is not active.

  • by the time CC_RTO is processed, the timeout processing routing

already will have pulled back snd_nxt from whereever it was, down
to snd_una.

  • snd_fack is not consistently pulled forward, only during SACK loss

recovery.

While these oversights have the opposite effect (snd_nxt == snd_una
would shrink the pipe, but leaving snd_fack aging (below snd_una),
would increase the non-6675 pipe, the general effect appears to be
an unintended inflated ssthresh.

When the (default) net.inet.tcp.sack.revised pipe calculation is
used, ssthresh will have the intended value (Flight Size * beta)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable