Page MenuHomeFreeBSD
Differential D43286

bhyveload: enter capability mode after we setup the vcpu
ClosedPublic
Actions

Authored by kevans on Jan 2 2024, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 9:21 AM
Unknown Object (File)
Sun, Feb 1, 2:25 AM
Unknown Object (File)
Sat, Jan 31, 7:40 PM
Unknown Object (File)
Thu, Jan 29, 10:42 PM
Unknown Object (File)
Thu, Jan 29, 7:01 PM
Unknown Object (File)
Sun, Jan 25, 1:16 PM
Unknown Object (File)
Sat, Jan 24, 11:24 PM
Unknown Object (File)
Sat, Jan 24, 6:33 PM
View All Files
Subscribers
allanjude
bcran
imp
jonathan
rgrimes

Details

Reviewers
markj
allanjude
emaste
Group Reviewers
bhyve
secteam
Commits
rG8bf0882e186e: bhyveload: enter capability mode after we setup the vcpu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jan 2 2024, 11:25 PM
Herald added subscribers: bcran, jonathan, rgrimes, imp. · View Herald TranscriptJan 2 2024, 11:25 PM
kevans requested review of this revision.Jan 2 2024, 11:25 PM
Harbormaster completed remote builds in B55208: Diff 132166.Jan 2 2024, 11:25 PM
kevans added a parent revision: D43285: bhyveload: hold /boot and do relative lookups for the loader.Jan 2 2024, 11:25 PM
allanjude accepted this revision.Jan 2 2024, 11:32 PM
allanjude added a subscriber: allanjude.

reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 2 2024, 11:32 PM
emaste accepted this revision.Jan 3 2024, 12:33 AM
markj added inline comments.Jan 3 2024, 3:12 PM
usr.sbin/bhyveload/bhyveload.c
872

I think we'll want to call caph_cache_catpages() first, to support the use of perror() in various places below.

kevans updated this revision to Diff 132214.Jan 3 2024, 6:04 PM
kevans marked an inline comment as done.

Address review feedback

This revision now requires review to proceed.Jan 3 2024, 6:04 PM
Harbormaster completed remote builds in B55222: Diff 132214.Jan 3 2024, 6:04 PM
emaste added a comment.Jan 3 2024, 6:37 PM

Perhaps we should add some more description or examples to capsicum_helpers(3) and/or capsicum(4)

markj accepted this revision as: markj.Jan 3 2024, 9:34 PM
This revision is now accepted and ready to land.Jan 3 2024, 9:34 PM
emaste accepted this revision.Jan 3 2024, 9:44 PM
Closed by commit rG8bf0882e186e: bhyveload: enter capability mode after we setup the vcpu (authored by kevans). · Explain WhyJan 3 2024, 10:21 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG8bf0882e186e: bhyveload: enter capability mode after we setup the vcpu.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyveload/
7 lines

Diff 132234

View Options

usr.sbin/bhyveload/bhyveload.c

Loading...