Page MenuHomeFreeBSD
Differential D43085

tcp: properly unroll sack transmission on tx error with LRD
ClosedPublic
Actions

Authored by rscheff on Dec 18 2023, 11:25 AM.
Tags
None
Referenced Files
F166532583: D43085.diff
Fri, Aug 14, 3:16 AM
Unknown Object (File)
Mon, Aug 10, 1:40 AM
Unknown Object (File)
Sun, Aug 9, 6:28 PM
Unknown Object (File)
Sun, Aug 9, 6:28 PM
Unknown Object (File)
Wed, Aug 5, 9:07 AM
Unknown Object (File)
Tue, Aug 4, 8:15 AM
Unknown Object (File)
Fri, Jul 17, 2:34 PM
Unknown Object (File)
Jul 9 2026, 1:54 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
cc
tuexen
thj
olivier
rrs
Group Reviewers
transport
Commits
rGac83f3fa44f3: tcp: properly unroll SACK transmission on TX error with LRD
rGe3b9058e5cd0: tcp: properly unroll sack transmission on tx error with LRD
Summary

While going over the code looing at PR275798, I spotted that
with LRD the rewind of the sackhole retransmission pointer
would not necessarily be calculcated correctly. In particular
with LRD, we point to snd_recover when a hole is fully retransmitted.
Need to account for that in case of a local transmission error.

PR: 275798
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 131520

View Options

sys/netinet/tcp_output.c

Loading...