Differential D42827

pci_cfgreg: Add a PCI domain argument to the low-level register API
ClosedPublic
Actions

Authored by jhb on Nov 28 2023, 11:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 12:15 AM

	Unknown Object (File)
	Thu, Jun 20, 4:03 AM

	Unknown Object (File)
	May 18 2024, 5:40 PM

	Unknown Object (File)
	May 8 2024, 11:44 AM

	Unknown Object (File)
	May 8 2024, 11:44 AM

	Unknown Object (File)
	May 8 2024, 9:36 AM

	Unknown Object (File)
	May 4 2024, 9:55 AM

	Unknown Object (File)
	Jan 18 2024, 11:39 PM

View All 15 Files

Subscribers

Details

Reviewers

imp
cperciva
andrew
manu

Group Reviewers

Commits

rG98b822fccd83: pci_cfgreg: Add a PCI domain argument to the low-level register API
rG325e60b1e652: pci_cfgreg: Add a PCI domain argument to the low-level register API
rG1587a9db92c0: pci_cfgreg: Add a PCI domain argument to the low-level register API

Summary

This commit changes the API of pci_cfgreg(read|write) to add a domain
argument (referred to as a segment in ACPI parlance) (note that this
is not the same as a NUMA domain, but something PCI-specific). This
does not yet enable access to domains other than 0, but updates the
API to support domains.

Places that use hard-coded bus/slot/function addresses have been
updated to hardcode a domain of 0. A few places that have the PCI
domain (segment) available such as the acpi_pcib_acpi.c Host-PCI
bridge driver pass the PCI domain.

The hpt27xx(4) and hptnr(4) drivers fail to attach to a device not on
domain 0 since they provide APIs to their binary blobs that only
permit bus/slot/function addressing.

The x86 non-ACPI PCI bus drivers all hardcode a domain of 0 as they
do not support multiple domains.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54682
Build 51571: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 28 2023, 11:32 PM

Herald added a reviewer: andrew. · View Herald TranscriptNov 28 2023, 11:32 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, rgrimes, emaste. · View Herald Transcript

jhb requested review of this revision.Nov 28 2023, 11:32 PM

jhb added a parent revision: D42826: agp_amd64: Use <machine/pci_cfgreg.h> rather than bare prototypes.

Harbormaster completed remote builds in B54682: Diff 130715.Nov 28 2023, 11:32 PM

jhb added a child revision: D42828: x86: Support multiple PCI MCFG regions.Nov 28 2023, 11:32 PM

imp accepted this revision.Nov 28 2023, 11:34 PM

This revision is now accepted and ready to land.Nov 28 2023, 11:34 PM

jhb added a child revision: D42829: x86: Refactor pcie_cfgregopen.Nov 28 2023, 11:50 PM

jhb removed a child revision: D42828: x86: Support multiple PCI MCFG regions.

Closed by commit rG1587a9db92c0: pci_cfgreg: Add a PCI domain argument to the low-level register API (authored by jhb). · Explain WhyNov 29 2023, 6:36 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1587a9db92c0: pci_cfgreg: Add a PCI domain argument to the low-level register API.

jhb added a commit: rG325e60b1e652: pci_cfgreg: Add a PCI domain argument to the low-level register API.Jan 18 2024, 11:39 PM

jhb added a commit: rG98b822fccd83: pci_cfgreg: Add a PCI domain argument to the low-level register API.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

pci/

62 lines

vmm/

amd/

2 lines

3 lines

arm64/

acpica/

5 lines

include/

4 lines

dev/

acpica/

Osd/

6 lines

acpi_pci_link.c

33 lines

acpi_pcib_acpi.c

8 lines

agp/

71 lines

amdtemp/

5 lines

hpt27xx/

hpt27xx_os_bsd.c

8 lines

hpt27xx_osm_bsd.c

5 lines

hptnr/

2 lines

hptnr_osm_bsd.c

5 lines

ichwd/

8 lines

ipmi/

2 lines

pci/

18 lines

3 lines

i386/

pci/

62 lines

10 lines

x86/

include/

4 lines

iommu/

2 lines

pci/

4 lines

pci_early_quirks.c

47 lines

2 lines

x86/

8 lines

Diff 130715

sys/amd64/pci/pci_cfgreg.c

Loading...

sys/amd64/vmm/amd/amdvi_hw.c

Loading...

sys/amd64/vmm/amd/ivrs_drv.c

Loading...

sys/arm64/acpica/pci_cfgreg.c

Loading...

sys/arm64/include/pci_cfgreg.h

Loading...

sys/dev/acpica/Osd/OsdHardware.c

Loading...

sys/dev/acpica/acpi_pci_link.c

Loading...

sys/dev/acpica/acpi_pcib_acpi.c

Loading...

sys/dev/agp/agp_amd64.c

Loading...

sys/dev/amdtemp/amdtemp.c

Loading...

sys/dev/hpt27xx/hpt27xx_os_bsd.c

Loading...

sys/dev/hpt27xx/hpt27xx_osm_bsd.c

Loading...

sys/dev/hptnr/hptnr_os_bsd.c

Loading...

sys/dev/hptnr/hptnr_osm_bsd.c

Loading...

sys/dev/ichwd/ichwd.c

Loading...

sys/dev/ipmi/ipmi_isa.c

Loading...

sys/dev/pci/pci_subr.c

Loading...

sys/dev/pci/pcib_private.h

Loading...

sys/i386/pci/pci_cfgreg.c

Loading...

sys/i386/pci/pci_pir.c

Loading...

sys/x86/include/pci_cfgreg.h

Loading...

sys/x86/iommu/intel_drv.c

Loading...

sys/x86/pci/pci_bus.c

Loading...

sys/x86/pci/pci_early_quirks.c

Loading...

sys/x86/pci/qpi.c

Loading...

sys/x86/x86/legacy.c

Loading...