Page MenuHomeFreeBSD

x86: make EARLY_AP_STARTUP mandatory
ClosedPublic

Authored by emaste on Aug 7 2023, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 3:05 AM
Unknown Object (File)
Tue, Nov 26, 1:13 PM
Unknown Object (File)
Nov 15 2024, 7:33 PM
Unknown Object (File)
Nov 15 2024, 6:22 PM
Unknown Object (File)
Nov 13 2024, 8:37 PM
Unknown Object (File)
Oct 23 2024, 12:17 AM
Unknown Object (File)
Sep 30 2024, 12:17 PM
Unknown Object (File)
Sep 30 2024, 6:21 AM
Subscribers

Details

Summary
When early AP startup was introduced in 2016 it was put behind a kernel
option EARLY_AP_STARTUP as a transition aid, so that it could be turned
off if necessary.  For x86 the non-EARLY_AP_STARTUP case is no longer
functional, so disallow it.

Other archs are still incompatible with EARLY_AP_STARTUP, so the option
cannot yet be removed entirely.

Reported by:    wollman
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Aug 7 2023, 9:03 PM
emaste created this revision.

see fdce57a04219d7a36c6646950fde6c8bcd97c044 for original commit that introduced the option

Move it from MINIMAL and GENERIC to DEFAULTS?

Still needs a mention in UPDATING.

Move it from MINIMAL and GENERIC to DEFAULTS?

D41352

Still needs a mention in UPDATING.

Indeed, although really it was needed months or years ago. @imp any suggestions on how to handle this case? Do we just add a note with today's date that mentions this was needed some time ago?

You could also remove some hideous ifdefs from dtrace_gethrtime_init_early() for i386 and amd64. I'm happy to do that separately though.

This revision is now accepted and ready to land.Sep 27 2023, 5:15 PM
This revision was automatically updated to reflect the committed changes.