Page MenuHomeFreeBSD
Differential D41350

Retire non-EARLY_AP_STARTUP code
Needs RevisionPublic
Actions

Authored by emaste on Aug 7 2023, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 7, 12:52 PM
Unknown Object (File)
Thu, Nov 6, 8:38 PM
Unknown Object (File)
Wed, Nov 5, 6:40 PM
Unknown Object (File)
Wed, Nov 5, 4:35 PM
Unknown Object (File)
Wed, Nov 5, 1:18 AM
Unknown Object (File)
Wed, Oct 29, 1:13 PM
Unknown Object (File)
Mon, Oct 27, 10:08 PM
Unknown Object (File)
Mon, Oct 27, 2:50 PM
View All 54 Files
Subscribers
ae
ehem_freebsd_m5p.com
glebius
jrtc27
melifaro
riscv

Details

Reviewers
jrtc27

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Aug 7 2023, 8:54 PM
Herald added subscribers: riscv, glebius, ehem_freebsd_m5p.com and 2 others. · View Herald TranscriptAug 7 2023, 8:54 PM
emaste requested review of this revision.Aug 7 2023, 8:54 PM
jrtc27 requested changes to this revision.Aug 7 2023, 8:56 PM
jrtc27 added a subscriber: jrtc27.

Uh, not all architectures currently support EARLY_AP_STARTUP. Even arm64 doesn't; there's a comment in the GICv3 driver for example about it IIRC.

This revision now requires changes to proceed.Aug 7 2023, 8:56 PM
jrtc27 added a comment.Aug 7 2023, 9:01 PM

The basic problem on arm64 is:

  • IPIs need an INTRNG PIC
  • INTRNG PIC needs newbus to probe up to at least BUS_PASS_INTERRUPT
  • newbus doesn't run until SI_SUB_DRIVERS
  • SI_SUB_SMP comes before SI_SUB_DRIVERS under EARLY_AP_STARTUP
emaste added a comment.Aug 7 2023, 9:13 PM

Uh, not all architectures currently support EARLY_AP_STARTUP

Yeah, I noticed this when only x86 config files needed modification. See D41351 for a proposed first step.

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
1 line
1 line
1 line
cddl/
dev/
dtrace/
amd64/
28 lines
29 lines
i386/
28 lines
powerpc/
5 lines
conf/
6 lines
1 line
dev/
acpica/
16 lines
5 lines
hwpmc/
4 lines
hyperv/
vmbus/
28 lines
kvm_clock/
34 lines
ntb/
ntb_hw/
19 lines
usb/
9 lines
xen/
control/
31 lines
geom/
eli/
8 lines
i386/
conf/
1 line
1 line
kern/
20 lines
15 lines
17 lines
47 lines
net/
27 lines
riscv/
riscv/
4 lines
5 lines
sys/
5 lines
x86/
isa/
8 lines
x86/
65 lines
14 lines
4 lines
5 lines

Diff 125670

View Options

sys/amd64/conf/FIRECRACKER

Loading...
View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/amd64/conf/MINIMAL

Loading...
View Options

sys/cddl/dev/dtrace/amd64/dtrace_subr.c

Loading...
View Options

sys/cddl/dev/dtrace/dtrace_load.c

Loading...
View Options

sys/cddl/dev/dtrace/i386/dtrace_subr.c

Loading...
View Options

sys/cddl/dev/dtrace/powerpc/dtrace_subr.c

Loading...
View Options

sys/conf/NOTES

Loading...
View Options

sys/conf/options

Loading...
View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/acpica/acpi_cpu.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_mod.c

Loading...
View Options

sys/dev/hyperv/vmbus/vmbus.c

Loading...
View Options

sys/dev/kvm_clock/kvm_clock.c

Loading...
View Options

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

Loading...
View Options

sys/dev/usb/usb_process.c

Loading...
View Options

sys/dev/xen/control/control.c

Loading...
View Options

sys/geom/eli/g_eli.c

Loading...
View Options

sys/i386/conf/GENERIC

Loading...
View Options

sys/i386/conf/MINIMAL

Loading...
View Options

sys/kern/kern_clocksource.c

Loading...
View Options

sys/kern/kern_cpu.c

Loading...
View Options

sys/kern/subr_epoch.c

Loading...
View Options

sys/kern/subr_intr.c

Loading...
View Options

sys/net/netisr.c

Loading...
View Options

sys/riscv/riscv/clock.c

Loading...
View Options

sys/riscv/riscv/mp_machdep.c

Loading...
View Options

sys/sys/kernel.h

Loading...
View Options

sys/x86/isa/clock.c

Loading...
View Options

sys/x86/x86/intr_machdep.c

Loading...
View Options

sys/x86/x86/local_apic.c

Loading...
View Options

sys/x86/x86/mca.c

Loading...
View Options

sys/x86/x86/mp_x86.c

Loading...