Page MenuHomeFreeBSD
Differential D40157

add defaults for adduser.sh (OK? [yes] & additional user [no])
ClosedPublic
Actions

Authored by admin_hackacad.net on May 18 2023, 7:54 PM.
Tags
None
Referenced Files
F82767994: D40157.id122130.diff
Thu, May 2, 10:37 AM
F82767879: D40157.id122243.diff
Thu, May 2, 10:35 AM
F82765487: D40157.id122243.diff
Thu, May 2, 10:01 AM
F82765413: D40157.id122130.diff
Thu, May 2, 9:59 AM
Unknown Object (File)
Mon, Apr 29, 10:28 PM
Unknown Object (File)
Mon, Apr 29, 10:58 AM
Unknown Object (File)
Fri, Apr 26, 12:34 AM
Unknown Object (File)
Thu, Apr 25, 9:54 PM
View All 49 Files
Subscribers
bcr
imp

Details

Reviewers
jhb
emaste
kevans
Commits
rG1da8405cdec4: add defaults for adduser.sh (OK? [yes] & additional user [no])
rG9efad6f9e108: add defaults for adduser.sh (OK? [yes] & additional user [no])
Summary

Updating Porters Handbook to use the proper tools for handling services.

Submitted by: Sven Ruediger <freebsd@hackacad.net>
Event: Kitchener-Waterloo Hackathon 202305
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

admin_hackacad.net requested review of this revision.May 18 2023, 7:54 PM
admin_hackacad.net created this revision.
admin_hackacad.net added a reviewer: jhb.May 18 2023, 9:02 PM
admin_hackacad.net updated this revision to Diff 122130.May 19 2023, 5:46 PM
jhb added a reviewer: emaste.May 22 2023, 7:57 PM
admin_hackacad.net updated this revision to Diff 122243.May 22 2023, 8:16 PM

update patch according to wiki/Phabricator

admin_hackacad.net updated this revision to Diff 122248.May 22 2023, 9:03 PM
emaste accepted this revision.May 22 2023, 10:07 PM

This LGTM. I suspect "All OK" might have intentionally had no default (to force the admin to pause and confirm) but IMO it really does not have a benefit.

This revision is now accepted and ready to land.May 22 2023, 10:07 PM
emaste added a reviewer: kevans.May 23 2023, 2:14 PM
admin_hackacad.net edited the summary of this revision. (Show Details)May 23 2023, 3:38 PM
jhb accepted this revision.May 23 2023, 9:01 PM
bcr added a subscriber: bcr.Jul 18 2023, 6:46 AM

Can someone commit this, please? Would be good to have.

jhb added a comment.Jul 18 2023, 5:34 PM
In D40157#934991, @bcr wrote:

Can someone commit this, please? Would be good to have.

Sure, can you just confirm the author details (my guess is "Sven Ruediger <admin@hackacad.net>")?

jhb added a comment.Jul 18 2023, 5:34 PM

Oh, nm, I see the author details are already there.

Closed by commit rG9efad6f9e108: add defaults for adduser.sh (OK? [yes] & additional user [no]) (authored by admin_hackacad.net, committed by jhb). · Explain WhyJul 18 2023, 5:39 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG9efad6f9e108: add defaults for adduser.sh (OK? [yes] & additional user [no]).
Herald added a subscriber: imp. · View Herald TranscriptJul 18 2023, 5:39 PM
des added a commit: rG1da8405cdec4: add defaults for adduser.sh (OK? [yes] & additional user [no]).Mon, Apr 29, 10:34 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
adduser/
14 lines

Diff 124804

View Options

usr.sbin/adduser/adduser.sh

Loading...