Differential D39538

Add new privilege PRIV_KDB_SET_BACKEND
ClosedPublic
Actions

Authored by stevek on Apr 12 2023, 5:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 24, 5:57 AM

	Unknown Object (File)
	Mon, Jun 22, 11:50 PM

	Unknown Object (File)
	Mon, Jun 22, 8:16 PM

	Unknown Object (File)
	Thu, Jun 11, 7:39 PM

	Unknown Object (File)
	Thu, Jun 11, 2:53 AM

	Unknown Object (File)
	Wed, Jun 10, 6:09 PM

	Unknown Object (File)
	Wed, Jun 10, 7:35 AM

	Unknown Object (File)
	Sun, Jun 7, 11:50 AM

View All 90 Files

Subscribers

Details

Reviewers

Commits

rG4819e5aeda4e: Add new privilege PRIV_KDB_SET_BACKEND

Summary

Check for PRIV_KDB_SET_BACKEND before allowing a thread to change
the KDB backend.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stevek created this revision.Apr 12 2023, 5:30 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 5:30 PM

stevek requested review of this revision.Apr 12 2023, 5:30 PM

Harbormaster completed remote builds in B50869: Diff 120225.Apr 12 2023, 5:30 PM

sjg accepted this revision.Apr 12 2023, 5:45 PM

sjg added a subscriber: sjg.

sjg added inline comments.

sys/sys/priv.h
526	I know this is updated via D39537 so ignoring

This revision is now accepted and ready to land.Apr 12 2023, 5:45 PM

emaste added a subscriber: emaste.Apr 12 2023, 7:18 PM

emaste added inline comments.Apr 12 2023, 7:22 PM

sys/sys/priv.h
519	I might expand this to "Kernel debugger privileges" (and in particular I might expect privileges related to e.g. ddb(4) to also land in here).
526	The tree should always be in a usable state so this should really update here and again in D39537

stevek added inline comments.Apr 12 2023, 7:48 PM

sys/sys/priv.h
519	Sure, makes sense. Maybe PRIV_DBG_SET_BACKEND for the name instead?
526	Yes, this one will come first. I have both commits in separate feature branches in my git tree.

Closed by commit rG4819e5aeda4e: Add new privilege PRIV_KDB_SET_BACKEND (authored by stevek). · Explain WhyApr 16 2023, 6:38 PM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rG4819e5aeda4e: Add new privilege PRIV_KDB_SET_BACKEND.

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

sys/

7 lines

Diff 120421

sys/kern/subr_kdb.c

Loading...

sys/sys/priv.h

Loading...