stand/userboot: Simplify code
ClosedPublic
Actions

Authored by imp on Apr 4 2023, 6:13 PM.

Details

Reviewers

allanjude
kevans
tsoome
manu
jhb

Group Reviewers

bhyve

Commits

rG5ce98ee5f42d: stand/userboot: Simplify code

Summary

We have way more than 8k of stack for the current value of the zfs
bootonce attribute. Allocate buf on the stack rather than the
complicated malloc / free dance.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50759
Build 47650: arc lint + arc unit

Event Timeline

imp created this revision.Apr 4 2023, 6:13 PM

Herald added a reviewer: bhyve. · View Herald TranscriptApr 4 2023, 6:13 PM

Herald added subscribers: dab, rgrimes. · View Herald Transcript

imp requested review of this revision.Apr 4 2023, 6:13 PM

imp added a parent revision: D39413: rc.d/zfsbe: Simplify.

imp added a child revision: D39415: stand/efi: Simplify code here.

Harbormaster completed remote builds in B50759: Diff 119845.Apr 4 2023, 6:13 PM

imp mentioned this in D39400: efi: Add zfs bootonce support to boot1.efi.Apr 4 2023, 6:16 PM

kevans accepted this revision.Apr 12 2023, 5:08 AM

This revision is now accepted and ready to land.Apr 12 2023, 5:08 AM

tsoome accepted this revision.Apr 12 2023, 6:16 AM

jhb accepted this revision.Apr 14 2023, 7:09 PM

Closed by commit rG5ce98ee5f42d: stand/userboot: Simplify code (authored by imp). · Explain WhyMay 1 2023, 9:04 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5ce98ee5f42d: stand/userboot: Simplify code.

Revision Contents
Changeset List

Path

Size

stand/

userboot/

main.c

18 lines

Diff 119845

View Options

stand/userboot/userboot/main.c

stand/userboot: Simplify codeClosedPublicActions