Paths

Table of Contentst

Differential D39285

bhyve: add bootindex option for several devices
ClosedPublic
Actions

Authored by corvink on Mar 27 2023, 10:29 AM.

Tags

None

Referenced Files

	F139380560: D39285.id119554.diff
	Thu, Dec 11, 12:02 PM

	Unknown Object (File)
	Sun, Dec 7, 6:12 PM

	Unknown Object (File)
	Sat, Dec 6, 10:01 PM

	Unknown Object (File)
	Thu, Nov 27, 4:36 PM

	Unknown Object (File)
	Oct 21 2025, 8:35 AM

	Unknown Object (File)
	Oct 19 2025, 12:45 AM

	Unknown Object (File)
	Oct 12 2025, 4:55 AM

	Unknown Object (File)
	Sep 29 2025, 9:52 AM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rGb02e0f964028: bhyve: add bootindex option for several devices
rG480bef9481f0: bhyve: add bootindex option for several devices

Summary

The bootindex option is used to specify the boot order. If no device
uses the bootindex option, the boot order will be determined by the
firmware. If one or more devices specify a bootindex, the first bootable
device with the lowest bootindex will be booted. It's not garanteed
that devices without a bootindex will be recognized as bootable from the
firmware in that case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50619
Build 47510: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 27 2023, 10:29 AM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 27 2023, 10:29 AM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Mar 27 2023, 10:29 AM

Harbormaster completed remote builds in B50600: Diff 119504.Mar 27 2023, 10:29 AM

corvink added a parent revision: D39284: bhyve: add helper to create a bootorder.Mar 27 2023, 10:30 AM

guest-patmaddox added a subscriber: guest-patmaddox.Mar 27 2023, 5:45 PM

jhb added inline comments.Mar 27 2023, 6:20 PM

usr.sbin/bhyve/block_if.c
478	()'s around return value
usr.sbin/bhyve/pci_ahci.c
2479	Trailing whitespace?

fix style issues

Harbormaster completed remote builds in B50619: Diff 119554.Mar 28 2023, 1:17 PM

corvink marked 2 inline comments as done.Mar 28 2023, 1:17 PM

@jhb @markj Any comments on this patch stack?

jhb accepted this revision.Jun 19 2023, 5:24 PM

This revision is now accepted and ready to land.Jun 19 2023, 5:24 PM

The documentation should explain that "bootorder" is just a qemu_fwcfg variable, and it's up to the guest firmware to do something with it.

usr.sbin/bhyve/block_if.c
69	Redundant include.
usr.sbin/bhyve/pci_virtio_scsi.c
716	`sc` is leaked here.

Closed by commit rG480bef9481f0: bhyve: add bootindex option for several devices (authored by corvink). · Explain WhyJun 20 2023, 8:53 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG480bef9481f0: bhyve: add bootindex option for several devices.

guest-patmaddox removed a subscriber: guest-patmaddox.Jul 29 2023, 5:39 AM

corvink added a commit: rGb02e0f964028: bhyve: add bootindex option for several devices.Aug 18 2023, 7:54 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

9 lines

2 lines

22 lines

7 lines

8 lines

pci_virtio_block.c

5 lines

pci_virtio_scsi.c

8 lines

Diff 119554

usr.sbin/bhyve/bhyve.8

Loading...

usr.sbin/bhyve/block_if.h

Loading...

usr.sbin/bhyve/block_if.c

Loading...

usr.sbin/bhyve/pci_ahci.c

Loading...

usr.sbin/bhyve/pci_nvme.c

Loading...

usr.sbin/bhyve/pci_virtio_block.c

Loading...

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...