Skip EFI framebuffer information if there is none
ClosedPublic
Actions

Authored by sjg on Feb 5 2023, 10:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 29, 3:03 PM

	Unknown Object (File)
	Sat, Jun 27, 2:56 PM

	Unknown Object (File)
	May 22 2026, 8:01 PM

	Unknown Object (File)
	Apr 30 2026, 2:23 AM

	Unknown Object (File)
	Apr 23 2026, 3:24 AM

	Unknown Object (File)
	Apr 21 2026, 5:42 PM

	Unknown Object (File)
	Apr 20 2026, 12:19 AM

	Unknown Object (File)
	Apr 19 2026, 8:58 PM

View All Files

Subscribers

bcran

dab

Details

Reviewers

stevek
tsoome
imp
manu

Commits

rG3cc3c1eb7961: Skip EFI framebuffer information if there is none

Summary

Avoid several lines of useless info if there is no EFI framebuffer

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.Feb 5 2023, 10:54 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 5 2023, 10:54 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

sjg requested review of this revision.Feb 5 2023, 10:54 PM

Harbormaster completed remote builds in B49544: Diff 116548.Feb 5 2023, 10:54 PM

This is as close to no-brainer yes that we can get...
While it;s theoretically possible that the frame buffer on some architectures (but not x86) is mapped at location 0, I can't imagine hardware designers ever actually doing that...

This revision is now accepted and ready to land.Feb 5 2023, 11:21 PM

Closed by commit rG3cc3c1eb7961: Skip EFI framebuffer information if there is none (authored by sjg). · Explain WhyFeb 6 2023, 1:24 AM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rG3cc3c1eb7961: Skip EFI framebuffer information if there is none.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

bootinfo.c

21 lines

Diff 116551

View Options

stand/efi/loader/bootinfo.c

Skip EFI framebuffer information if there is noneClosedPublicActions