Skip EFI framebuffer information if there is none
ClosedPublic
Actions

Authored by sjg on Feb 5 2023, 10:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 23, 10:06 PM

	Unknown Object (File)
	Thu, Aug 20, 7:51 PM

	Unknown Object (File)
	Thu, Aug 20, 7:50 PM

	Unknown Object (File)
	Tue, Aug 11, 11:28 AM

	Unknown Object (File)
	Wed, Aug 5, 8:33 AM

	Unknown Object (File)
	Wed, Aug 5, 7:43 AM

	Unknown Object (File)
	Tue, Aug 4, 9:08 AM

	Unknown Object (File)
	Jul 21 2026, 4:20 PM

View All Files

Subscribers

bcran

dab

Details

Reviewers

stevek
tsoome
imp
manu

Commits

rG3cc3c1eb7961: Skip EFI framebuffer information if there is none

Summary

Avoid several lines of useless info if there is no EFI framebuffer

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.Feb 5 2023, 10:54 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 5 2023, 10:54 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

sjg requested review of this revision.Feb 5 2023, 10:54 PM

Harbormaster completed remote builds in B49544: Diff 116548.Feb 5 2023, 10:54 PM

This is as close to no-brainer yes that we can get...
While it;s theoretically possible that the frame buffer on some architectures (but not x86) is mapped at location 0, I can't imagine hardware designers ever actually doing that...

This revision is now accepted and ready to land.Feb 5 2023, 11:21 PM

Closed by commit rG3cc3c1eb7961: Skip EFI framebuffer information if there is none (authored by sjg). · Explain WhyFeb 6 2023, 1:24 AM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rG3cc3c1eb7961: Skip EFI framebuffer information if there is none.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

bootinfo.c

21 lines

Diff 116551

View Options

stand/efi/loader/bootinfo.c

Skip EFI framebuffer information if there is noneClosedPublicActions