Paths

Table of Contentst

bhyve: add helper func to write a dsdt entry
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:09 AM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG6726130d6860: bhyve: add helper func to write a dsdt entry
rG682a522d6122: bhyve: add helper func to write a dsdt entry

Summary

The guest will check the dsdt to detect acpi devices. Therefore, add a
helper function to create such a dsdt entry for an acpi device.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49401
Build 46291: arc lint + arc unit

Event Timeline

corvink created this revision.Feb 1 2023, 11:09 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:09 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Feb 1 2023, 11:09 AM

Harbormaster completed remote builds in B49401: Diff 116185.Feb 1 2023, 11:09 AM

corvink mentioned this in D33767: bhyve: add helper struct for ACPI device handling.Feb 1 2023, 11:13 AM

corvink added a parent revision: D38328: bhyve: add helper func to add acpi resources.

corvink added a child revision: D38330: bhyve: maintain a list of acpi devices.

markj added inline comments.Feb 2 2023, 2:15 PM

usr.sbin/bhyve/acpi_device.c
149
165	Can this only happen due to a programming error? Should this then be a fatal error?

fix style
assert on unknown resource type

Harbormaster completed remote builds in B49589: Diff 116678.Feb 7 2023, 7:43 AM

corvink marked an inline comment as done.Feb 7 2023, 7:47 AM

corvink added inline comments.

usr.sbin/bhyve/acpi_device.c
165	Should only happen due to a programming error. I'm not sure about the prefered style. I'm using `assert(0)` like some other part of bhyve.

markj accepted this revision as: markj.Feb 10 2023, 4:37 PM

markj added inline comments.

usr.sbin/bhyve/acpi_device.c
159	No need for braces here. Or maybe you add some local var in a later patch.

This revision is now accepted and ready to land.Feb 10 2023, 4:37 PM

Closed by commit rG682a522d6122: bhyve: add helper func to write a dsdt entry (authored by corvink). · Explain WhyFeb 14 2023, 7:29 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG682a522d6122: bhyve: add helper func to write a dsdt entry.

corvink added a commit: rG6726130d6860: bhyve: add helper func to write a dsdt entry.Feb 28 2023, 10:14 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

acpi_device.h

2 lines

acpi_device.c

49 lines

Diff 116185

View Options

usr.sbin/bhyve/acpi_device.h