Page MenuHomeFreeBSD

bhyve: add helper func to write a dsdt entry
ClosedPublic

Authored by corvink on Feb 1 2023, 11:09 AM.
Tags
None
Referenced Files
F100033599: D38329.diff
Mon, Oct 14, 5:22 AM
Unknown Object (File)
Tue, Oct 8, 6:45 AM
Unknown Object (File)
Sun, Oct 6, 11:10 PM
Unknown Object (File)
Wed, Sep 18, 9:03 PM
Unknown Object (File)
Tue, Sep 17, 4:16 PM
Unknown Object (File)
Tue, Sep 17, 9:19 AM
Unknown Object (File)
Sun, Sep 15, 8:54 PM
Unknown Object (File)
Sep 11 2024, 7:36 AM
Subscribers

Details

Summary

The guest will check the dsdt to detect acpi devices. Therefore, add a
helper function to create such a dsdt entry for an acpi device.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49589
Build 46479: arc lint + arc unit

Event Timeline

usr.sbin/bhyve/acpi_device.c
144
160

Can this only happen due to a programming error? Should this then be a fatal error?

  • fix style
  • assert on unknown resource type
corvink added inline comments.
usr.sbin/bhyve/acpi_device.c
160

Should only happen due to a programming error. I'm not sure about the prefered style. I'm using assert(0) like some other part of bhyve.

markj added inline comments.
usr.sbin/bhyve/acpi_device.c
154

No need for braces here. Or maybe you add some local var in a later patch.

This revision is now accepted and ready to land.Feb 10 2023, 4:37 PM
This revision was automatically updated to reflect the committed changes.