Add kf_file_nlink field to kf_file and populate it
ClosedPublic
Actions

Authored by c_jia.je on Jan 23 2023, 1:05 PM.

Details

Reviewers: None
Commits: rGba1fc13882d1: Add kf_file_nlink field to kf_file and populate it
rGdec7db49602d: Add kf_file_nlink field to kf_file and populate it

Summary

This will allow user-space programs (e.g. lsof) to locate deleted files
whose nlink equals to zero. Prior to this commit, programs has to use
stat(kf_path) to get nlink, but that will fail if the file is deleted.

Test Plan

Tested the patch with changes in lsof to list deleted files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49195
Build 46084: arc lint + arc unit

Event Timeline

c_jia.je created this revision.Jan 23 2023, 1:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2023, 1:05 PM

c_jia.je requested review of this revision.Jan 23 2023, 1:05 PM

Harbormaster completed remote builds in B49195: Diff 115442.Jan 23 2023, 1:05 PM

Huh, I did not even realize this information was missing.

I'll probably commit in a day or two. Can you show me the matching lsof diff if you have it ready?

In D38169#867072, @mjg wrote:

Huh, I did not even realize this information was missing.

I'll probably commit in a day or two. Can you show me the matching lsof diff if you have it ready?

Sure, you can find it at https://github.com/lsof-org/lsof/commit/4e0aaacf290133859d0f5ac205311079bc9fb170

can you send me the commit generated with git format-patch so that I have something nice to apply? mjg@

I would change "Number of references to file." to "Link count." but I'm not going to insist.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2023, 6:14 PM

Closed by commit rGdec7db49602d: Add kf_file_nlink field to kf_file and populate it (authored by c_jia.je, committed by mjg). · Explain Why

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rGdec7db49602d: Add kf_file_nlink field to kf_file and populate it.

mjg added a commit: rGba1fc13882d1: Add kf_file_nlink field to kf_file and populate it.Jan 29 2023, 2:38 PM