Page MenuHomeFreeBSD
Differential D37566

net: add if_allocdescr() to permit updating interface description from the kernel
ClosedPublic
Actions

Authored by melifaro on Nov 30 2022, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 7:08 PM
Unknown Object (File)
Mon, Nov 25, 8:22 PM
Unknown Object (File)
Fri, Nov 22, 4:15 AM
Unknown Object (File)
Thu, Nov 21, 6:45 AM
Unknown Object (File)
Mon, Nov 18, 4:54 PM
Unknown Object (File)
Mon, Nov 18, 1:20 PM
Unknown Object (File)
Sun, Nov 17, 7:12 PM
Unknown Object (File)
Sun, Nov 17, 1:46 PM
View All 57 Files
Subscribers
ae
glebius
imp
kp
zlei

Details

Reviewers
kp
zlei
Group Reviewers
network
Commits
rG40c711523e3a: net: add if_allocdescr() to permit updating iface description from the kernel
rG984b27d879e1: net: add if_allocdescr() to permit updating iface description from the kernel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.Nov 30 2022, 1:50 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptNov 30 2022, 1:50 PM
melifaro requested review of this revision.Nov 30 2022, 1:50 PM
Harbormaster completed remote builds in B48567: Diff 113674.Nov 30 2022, 1:50 PM
melifaro edited the summary of this revision. (Show Details)Nov 30 2022, 1:50 PM
melifaro added a reviewer: network.
melifaro retitled this revision from net: add if_allocdescr() to permit updating description from the kernel to net: add if_allocdescr() to permit updating interface description from the kernel.
kp added a subscriber: kp.Nov 30 2022, 2:33 PM

Does this abstract enough to be worth it? Where is it intended to be used?

sys/net/if.c
4276

I think our usual pattern for this sort of thing is to pass int flags, and do malloc(size, type, M_ZERO | flags).

4278

Also, I'm sure you meant (waitok ? M_WAITOK : 0) here.

melifaro added a comment.Nov 30 2022, 2:41 PM
In D37566#853879, @kp wrote:

Does this abstract enough to be worth it? Where is it intended to be used?

I have a larger diff that allows netlink to update interface properties, such as description. Given we already have if_freedescr(), I moved towards the if_allocdescr() instead of exposing M_IFDESCR.

melifaro updated this revision to Diff 113676.Nov 30 2022, 2:57 PM

.

Harbormaster completed remote builds in B48568: Diff 113676.Nov 30 2022, 2:57 PM
kp accepted this revision as: kp.Nov 30 2022, 3:42 PM
This revision is now accepted and ready to land.Nov 30 2022, 3:42 PM
zlei accepted this revision.Dec 1 2022, 7:57 AM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rG984b27d879e1: net: add if_allocdescr() to permit updating iface description from the kernel (authored by melifaro). · Explain WhyDec 1 2022, 11:33 AM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG984b27d879e1: net: add if_allocdescr() to permit updating iface description from the kernel.
melifaro added a commit: rG40c711523e3a: net: add if_allocdescr() to permit updating iface description from the kernel.Jan 23 2023, 10:15 PM
melifaro mentioned this in rG6694cb1f5784: netlink: fix if_allocdescr() malloc options argument..Feb 17 2023, 6:17 PM
melifaro mentioned this in rG8c60d469d3fa: netlink: fix if_allocdescr() malloc options argument..Feb 18 2023, 12:12 PM
melifaro mentioned this in rG816aebf69c3d: netlink: fix if_allocdescr() malloc options argument..Feb 20 2023, 8:13 PM

Revision Contents
Changeset List

PathSize
sys/
net/
10 lines
1 line

Diff 113742

View Options

sys/net/if.c

Loading...
View Options

sys/net/if_var.h

Loading...