ipsec: add support for CHACHA20POLY1305
ClosedPublic
Actions

Authored by kp on Oct 27 2022, 6:58 PM.

Details

Reviewers

gbe
pauamma_gundo.com

Group Reviewers

Commits

rG9f8f3a8e9ad4: ipsec: add support for CHACHA20POLY1305

Summary

Based on a patch by ae@.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kp created this revision.Oct 27 2022, 6:58 PM

kp requested review of this revision.Oct 27 2022, 6:58 PM

LGTM for the man page parts.

This revision is now accepted and ready to land.Oct 27 2022, 8:17 PM

English LGTM. Can't say more.

Looks good to me, for the remaining part.

sys/net/pfkeyv2.h
391	It seems `SADB_X_EALG_AESCCM16` is not related to chacha cipher. Is that missing in some previous commit ? If so I'd suggested to commit separately and it will be easy to MFCed.

Remove unused SADB_X_EALG_AESCCM16 definition

This revision now requires review to proceed.Oct 28 2022, 2:07 PM

kp marked an inline comment as done.Oct 28 2022, 2:08 PM

kp added inline comments.

sys/net/pfkeyv2.h
391	Good catch. The patch this is based on also added CCM. I've not been able to test that, so it's not part of this patch, but I failed to remove this definition.