[PATCH 11/19] bhyve: build FACS table by basl

[corvink]

Summary

Building the FACS table by basl will allow it to be loaded by qemu's
ACPI table loader.

This is the 11. patch required to merge D36983

[jhb]

usr.sbin/bhyve/acpi.c

943

Note that an alternative could be using an existing structure from an ACPI-CA header and populating the fields using htoleXX() when needed, e.g. something like:

ACPI_TABLE_FACS facs;

memset(&facs, 0, sizeof(facs));
/* Populate fields */

BASL_EXEC(basl_table_append_bytes(facts_table, facs, sizeof(facs));

Note that actbl.h explicitly notes that the FACS does not use the common ACPI table header (ACPI_TABLE_HEADER).

[jhb]

usr.sbin/bhyve/acpi.c

943

I went back and noticed you took the approach I suggested for ACPI_TABLE_HEADER, and I do think it would be more readable to do that here as well.

[corvink]

• use ACPI_TABLE_FACS struct to build facs

[corvink]

• fix build

[corvink]

• use ACPI_TABLE_FACS to build the FACS