Page MenuHomeFreeBSD

bhyve: add helper to append a basl table without a header
ClosedPublic

Authored by corvink on Wed, Nov 16, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 3, 2:06 AM
Unknown Object (File)
Sat, Dec 3, 2:05 AM
Unknown Object (File)
Sat, Dec 3, 2:05 AM
Unknown Object (File)
Mon, Nov 28, 3:39 PM
Subscribers

Details

Summary

The common style for build an ACPI table will be:

  1. basl_table_create
  2. basl_table_append_header
  3. setup an ACPI_TABLE_* struct
  4. basl_table_append_bytes (without header)

Add a helper for the last step.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
usr.sbin/bhyve/basl.c
443

Assert len >= sizeof(ACPI_TABLE_HEADER)?

447

Missing parens around the return value.

usr.sbin/bhyve/basl.h
56
This revision is now accepted and ready to land.Wed, Nov 16, 2:25 PM

Agree with @markj's feedback, but like the idea of a helper function for this.