[PATCH 18/19] bhyve: build RSDP table by basl
ClosedPublic
Actions

Authored by corvink on Oct 14 2022, 9:31 AM.

Details

Reviewers

jhb
markj
rew

Group Reviewers

bhyve

Commits

rG6c5f461fe9d9: bhyve: build RSDP table by basl
rG03e7111fa606: bhyve: build RSDP table by basl

Summary

Building the RSDP table by basl will allow it to be loaded by qemu's
ACPI table loader.

This is the 18. patch required to merge D36983

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Oct 14 2022, 9:31 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 14 2022, 9:31 AM

corvink requested review of this revision.Oct 14 2022, 9:31 AM

corvink mentioned this in D36983: bhyve: improve acpi table generation.Oct 14 2022, 9:35 AM

corvink retitled this revision from [acpi-table part 18] bhyve: build RSDP table by basl to [PATCH 18/19] bhyve: build RSDP table by basl.Oct 14 2022, 9:45 AM

markj accepted this revision as: markj.Nov 2 2022, 1:55 PM

markj added inline comments.

usr.sbin/bhyve/acpi.c
779	This comment isn't really accurate anymore, here we're just building up representations of the tables.

This revision is now accepted and ready to land.Nov 2 2022, 1:55 PM

jhb added a child revision: D37002: [PATCH 19/19] bhyve: use dynamic ACPI table offsets.Nov 10 2022, 6:33 PM

jhb added a parent revision: D37000: [PATCH 17/19] bhyve: build RSDT table by basl.

inline defines

This revision now requires review to proceed.Nov 15 2022, 10:09 AM

Harbormaster completed remote builds in B48353: Diff 113131.Nov 15 2022, 10:09 AM

jhb added inline comments.Nov 15 2022, 6:58 PM

usr.sbin/bhyve/acpi.c
694	Might also be nice to use ACPI_TABLE_RSDP here (but would need basl_table_add_pointer).
771	Might be nice to still say something like "Generate ACPI tables and copy them into guest memory."