Differential D37407

bhyve: add helper to fill a ACPI_GENERIC_ADDRESS
ClosedPublic
Actions

Authored by corvink on Nov 16 2022, 12:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 18, 7:27 PM

	Unknown Object (File)
	Fri, Apr 17, 11:12 AM

	Unknown Object (File)
	Fri, Apr 17, 9:26 AM

	Unknown Object (File)
	Tue, Apr 14, 9:33 PM

	Unknown Object (File)
	Tue, Apr 14, 4:13 AM

	Unknown Object (File)
	Tue, Apr 14, 2:11 AM

	Unknown Object (File)
	Sat, Apr 11, 12:22 PM

	Unknown Object (File)
	Fri, Apr 10, 5:27 PM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rGf3085b5d29cc: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS
rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Nov 16 2022, 12:51 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptNov 16 2022, 12:51 PM

corvink requested review of this revision.Nov 16 2022, 12:51 PM

Harbormaster completed remote builds in B48385: Diff 113200.Nov 16 2022, 12:51 PM

Why does it need to be inline?

corvink added a child revision: D36996: [PATCH 13/19] bhyve: build HPET table by basl.Nov 17 2022, 7:31 AM

corvink added a parent revision: D36995: [PATCH 12/19] bhyve: build MCFG table by basl.

I'm ambivalent as to whether it should be inline or in basl.c. None of these code paths are performance critical which would otherwise be a reason to make it an inline.

This revision is now accepted and ready to land.Nov 17 2022, 5:56 PM

Closed by commit rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS (authored by corvink). · Explain WhyNov 21 2022, 8:32 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS.

corvink added a commit: rGf3085b5d29cc: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS.Dec 5 2022, 7:42 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

3 lines

14 lines

Diff 113361

usr.sbin/bhyve/basl.h

Loading...

usr.sbin/bhyve/basl.c

Loading...