Page MenuHomeFreeBSD
Differential D37407

bhyve: add helper to fill a ACPI_GENERIC_ADDRESS
ClosedPublic
Actions

Authored by corvink on Nov 16 2022, 12:51 PM.
Tags
None
Referenced Files
F108738779: D37407.diff
Mon, Jan 27, 3:42 PM
Unknown Object (File)
Wed, Jan 8, 6:53 PM
Unknown Object (File)
Wed, Jan 8, 6:52 PM
Unknown Object (File)
Wed, Jan 8, 6:52 PM
Unknown Object (File)
Wed, Jan 8, 3:57 PM
Unknown Object (File)
Nov 27 2024, 12:36 PM
Unknown Object (File)
Nov 24 2024, 4:42 PM
Unknown Object (File)
Nov 15 2024, 6:06 PM
View All 88 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rGf3085b5d29cc: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS
rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48385
Build 45271: arc lint + arc unit

Event Timeline

corvink created this revision.Nov 16 2022, 12:51 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptNov 16 2022, 12:51 PM
corvink requested review of this revision.Nov 16 2022, 12:51 PM
Harbormaster completed remote builds in B48385: Diff 113200.Nov 16 2022, 12:51 PM
markj added a comment.Nov 16 2022, 2:26 PM

Why does it need to be inline?

corvink added a child revision: D36996: [PATCH 13/19] bhyve: build HPET table by basl.Nov 17 2022, 7:31 AM
corvink added a parent revision: D36995: [PATCH 12/19] bhyve: build MCFG table by basl.
jhb accepted this revision.Nov 17 2022, 5:56 PM

I'm ambivalent as to whether it should be inline or in basl.c. None of these code paths are performance critical which would otherwise be a reason to make it an inline.

This revision is now accepted and ready to land.Nov 17 2022, 5:56 PM
Closed by commit rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS (authored by corvink). · Explain WhyNov 21 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG60277ad75ec9: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS.
corvink added a commit: rGf3085b5d29cc: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS.Dec 5 2022, 7:42 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
14 lines

Diff 113200

View Options

usr.sbin/bhyve/basl.h

Loading...