Differential D36828

bhyve: Don't free an invalid pointer.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:39 PM.

Details

Reviewers

markj

Group Reviewers

bhyve

Commits

rG6728d270e132: bhyve: Don't free an invalid pointer.
rG2fb81691b02f: bhyve: Don't free an invalid pointer.

Summary

The netmap-specific data stored at be->opaque is freed by the caller
on error as part of freeing be.

Reported by: GCC -Wfree-nonheap-object

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 29 2022, 10:39 PM

Herald added a reviewer: bhyve. · View Herald TranscriptSep 29 2022, 10:39 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Sep 29 2022, 10:39 PM

Harbormaster completed remote builds in B47642: Diff 111248.Sep 29 2022, 10:40 PM

jhb added a child revision: D36829: bhyve: Avoid triggering false -Wfree-nonheap-object warnings..Sep 29 2022, 10:40 PM

jhb added a parent revision: D36827: nvmecontrol wdc: Don't pass a bogus pointer to free()..Sep 29 2022, 10:40 PM

markj accepted this revision as: markj.Sep 30 2022, 2:35 PM

This revision is now accepted and ready to land.Sep 30 2022, 2:35 PM

Closed by commit rG2fb81691b02f: bhyve: Don't free an invalid pointer. (authored by jhb). · Explain WhyOct 3 2022, 11:14 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2fb81691b02f: bhyve: Don't free an invalid pointer..

jhb added a commit: rG6728d270e132: bhyve: Don't free an invalid pointer..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

net_backends.c

1 line

Diff 111397

View Options

usr.sbin/bhyve/net_backends.c

bhyve: Don't free an invalid pointer.ClosedPublicActions