nvmecontrol wdc: Don't pass a bogus pointer to free().
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:39 PM.

Details

Reviewers

Commits

rG7597246911f8: nvmecontrol wdc: Don't pass a bogus pointer to free().
rG1187e46d1b38: nvmecontrol wdc: Don't pass a bogus pointer to free().

Summary

wdc_get_dui_log_size allocates a buffer and then advances the
returned pointer. Passing this advanced pointer to free() is UB,
so save the original pointer to pass to free() instead.

Reported by: GCC 12 -Wfree-nonheap-object

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 29 2022, 10:39 PM

Herald added a subscriber: dab. · View Herald TranscriptSep 29 2022, 10:39 PM

jhb requested review of this revision.Sep 29 2022, 10:39 PM

Harbormaster completed remote builds in B47641: Diff 111247.Sep 29 2022, 10:39 PM

jhb added a child revision: D36828: bhyve: Don't free an invalid pointer..Sep 29 2022, 10:40 PM

imp accepted this revision.Sep 30 2022, 2:58 AM

This revision is now accepted and ready to land.Sep 30 2022, 2:58 AM

Closed by commit rG1187e46d1b38: nvmecontrol wdc: Don't pass a bogus pointer to free(). (authored by jhb). · Explain WhyOct 3 2022, 11:14 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1187e46d1b38: nvmecontrol wdc: Don't pass a bogus pointer to free()..

jhb added a commit: rG7597246911f8: nvmecontrol wdc: Don't pass a bogus pointer to free()..Nov 11 2022, 6:44 PM

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

modules/

wdc/

wdc.c

6 lines

Diff 111394

View Options

sbin/nvmecontrol/modules/wdc/wdc.c

nvmecontrol wdc: Don't pass a bogus pointer to free().ClosedPublicActions