arm64 pmap: batch chunk removal in pmap_remove_pages
ClosedPublic
Actions

Authored by andrew on Aug 23 2022, 10:15 AM.

Details

Reviewers

alc
kib
markj
mjg
manu

Group Reviewers

arm64

Commits

rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages

Summary

As with amd64 batch chunk removal in pmap_remove_pages to move it out
of the pv list lock. This is one of the main contested locks when
running poudriere on a 160 core Ampere Altra server.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 23 2022, 10:15 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 23 2022, 10:15 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Aug 23 2022, 10:15 AM

Harbormaster completed remote builds in B47069: Diff 109705.Aug 23 2022, 10:15 AM

markj added inline comments.Aug 29 2022, 3:05 PM

sys/arm64/arm64/pmap.c
2775	Missing newline.
5440	Do pv chunks need to be freed under the pmap lock?

andrew added inline comments.Aug 31 2022, 11:18 AM

sys/arm64/arm64/pmap.c
5440	It's the same as amd64. If the comments in D21832 don't apply here I can move it.

alc added inline comments.Aug 31 2022, 4:54 PM

sys/arm64/arm64/pmap.c
5440	No, don't move it. The same reason applies here.

Add a missing newline

Harbormaster completed remote builds in B47260: Diff 110209.Sep 6 2022, 12:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2022, 3:15 PM

Closed by commit rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG92d73b0b2564: arm64 pmap: batch chunk removal in pmap_remove_pages.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

41 lines

Diff 111081

View Options

arm64 pmap: batch chunk removal in pmap_remove_pagesClosedPublicActions