Page MenuHomeFreeBSD
Differential D36062

inpcb: gather v4/v6 handling code into in_pcballoc() from protocols
ClosedPublic
Actions

Authored by glebius on Aug 7 2022, 7:16 PM.
Tags
None
Referenced Files
F170219549: D36062.diff
Thu, Sep 3, 10:17 PM
F170082015: D36062.id108946.diff
Thu, Sep 3, 11:17 AM
Unknown Object (File)
Wed, Sep 2, 9:39 PM
Unknown Object (File)
Wed, Sep 2, 1:44 PM
Unknown Object (File)
Tue, Sep 1, 10:40 PM
Unknown Object (File)
Tue, Sep 1, 6:50 PM
Unknown Object (File)
Tue, Sep 1, 11:25 AM
Unknown Object (File)
Mon, Aug 31, 6:34 PM
View All Files
Subscribers
ae
bz
imp
melifaro

Details

Reviewers
rrs
tuexen
Group Reviewers
network
transport
Commits
rGc7a62c925c81: inpcb: gather v4/v6 handling code into in_pcballoc() from protocols

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Aug 7 2022, 7:16 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptAug 7 2022, 7:16 PM
Herald added subscribers: melifaro, bz, ae, imp. · View Herald Transcript
glebius requested review of this revision.Aug 7 2022, 7:16 PM
Harbormaster completed remote builds in B46769: Diff 108946.Aug 7 2022, 7:16 PM
glebius added a child revision: D36063: sockets: provide solisten_clone(), solisten_enqueue().Aug 7 2022, 7:16 PM
glebius mentioned this in D35730: tcp: keep the inp locked while processing the ACK of the handshake.Aug 7 2022, 7:23 PM
rrs accepted this revision.Aug 8 2022, 5:40 PM
This revision is now accepted and ready to land.Aug 8 2022, 5:40 PM
bz added inline comments.Aug 8 2022, 7:12 PM
sys/netinet/in_pcb.c
643

Will this affect raw IPv6 sockets? I think someone should write regression tests with V4 mapped V6 addresses for that...

tuexen accepted this revision as: tuexen.Aug 8 2022, 7:25 PM
glebius added inline comments.Aug 9 2022, 4:30 AM
sys/netinet/in_pcb.c
643

Will this affect raw IPv6 sockets? I think someone should write regression tests with V4 mapped V6 addresses for that...

Why should it? Raw sockets do not check these flags.

Closed by commit rGc7a62c925c81: inpcb: gather v4/v6 handling code into in_pcballoc() from protocols (authored by glebius). · Explain WhyAug 10 2022, 6:10 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGc7a62c925c81: inpcb: gather v4/v6 handling code into in_pcballoc() from protocols.

Revision Contents
Changeset List

PathSize
sys/
netinet/
17 lines
1 line
1 line
10 lines
1 line
netinet6/
2 lines
4 lines

Diff 109112

View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet/ip_divert.c

Loading...
View Options

sys/netinet/raw_ip.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...
View Options

sys/netinet/udp_usrreq.c

Loading...
View Options

sys/netinet6/raw_ip6.c

Loading...
View Options

sys/netinet6/udp6_usrreq.c

Loading...