Page MenuHomeFreeBSD

bhyve nvme: Fix Controller init error cases
ClosedPublic

Authored by chuck on Jun 10 2022, 9:11 PM.
Tags
None
Referenced Files
F137268745: D35453.id109328.diff
Fri, Nov 21, 10:58 PM
Unknown Object (File)
Mon, Nov 17, 1:34 PM
Unknown Object (File)
Mon, Nov 17, 4:33 AM
Unknown Object (File)
Mon, Nov 17, 3:31 AM
Unknown Object (File)
Sun, Nov 16, 1:55 PM
Unknown Object (File)
Sun, Nov 16, 8:08 AM
Unknown Object (File)
Wed, Nov 5, 7:57 PM
Unknown Object (File)
Tue, Oct 28, 11:41 PM
Subscribers

Details

Summary

Fuzzing of bhyve uncovered an assertion failure in the NVMe emulation.
Investigation uncovered several corner cases the code did not handle.
This change handles several Controller initialization errors, including

  • bad AQ sizes
  • bad AQ vm_map_gpa
  • doorbell writes prior to RDY
  • doorbell writes to uninitialized queue
  • CSTS.RDY if CFS set

PR: 256317,256319,256320,256322
Reported by: Cheolwoo Myung <cwmyung@snu.ac.kr>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable