Page MenuHomeFreeBSD
Differential D35453

bhyve nvme: Fix Controller init error cases
ClosedPublic
Actions

Authored by chuck on Jun 10 2022, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 19, 11:09 AM
Unknown Object (File)
Sat, Apr 18, 2:17 PM
Unknown Object (File)
Sat, Apr 18, 5:33 AM
Unknown Object (File)
Fri, Apr 17, 9:57 PM
Unknown Object (File)
Thu, Apr 16, 12:09 PM
Unknown Object (File)
Tue, Apr 7, 9:53 AM
Unknown Object (File)
Mar 26 2026, 5:43 AM
Unknown Object (File)
Mar 25 2026, 6:14 PM
View All Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
Group Reviewers
bhyve
Commits
rG6c708e91f447: bhyve nvme: Fix Controller init error cases
rGd7d1becad4b6: bhyve nvme: Fix Controller init error cases
Summary

Fuzzing of bhyve uncovered an assertion failure in the NVMe emulation.
Investigation uncovered several corner cases the code did not handle.
This change handles several Controller initialization errors, including

  • bad AQ sizes
  • bad AQ vm_map_gpa
  • doorbell writes prior to RDY
  • doorbell writes to uninitialized queue
  • CSTS.RDY if CFS set

PR: 256317,256319,256320,256322
Reported by: Cheolwoo Myung <cwmyung@snu.ac.kr>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
55 lines

Diff 109328

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...