Page MenuHomeFreeBSD
Differential D35247

arm64: Enable Floating-point exception
ClosedPublic
Actions

Authored by dchagin on May 18 2022, 6:49 PM.
Tags
None
Referenced Files
F133282988: D35247.id106159.diff
Fri, Oct 24, 2:56 PM
Unknown Object (File)
Fri, Oct 17, 4:35 PM
Unknown Object (File)
Fri, Oct 17, 2:35 AM
Unknown Object (File)
Mon, Oct 13, 7:43 AM
Unknown Object (File)
Sat, Oct 11, 2:38 PM
Unknown Object (File)
Sat, Oct 11, 2:38 PM
Unknown Object (File)
Sat, Oct 11, 2:38 PM
Unknown Object (File)
Sat, Oct 11, 2:37 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
andrew
Group Reviewers
arm64
Commits
rG570206bdc227: arm64: Enable the floating-point exception traps
rG6e2caba7a129: arm64: Enable the floating-point exception traps
Summary

To enable it user-space needs to call feenableexcept().

FPE_FLTIDO has been added ss IDF bit can't be mapped to any existing FPE code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45623
Build 42511: arc lint + arc unit

Event Timeline

dchagin created this revision.May 18 2022, 6:49 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 18 2022, 6:49 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
dchagin requested review of this revision.May 18 2022, 6:49 PM
Harbormaster completed remote builds in B45623: Diff 106144.May 18 2022, 6:49 PM
dchagin added a reviewer: arm64.May 18 2022, 6:50 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
andrew added inline comments.May 18 2022, 7:14 PM
sys/arm64/arm64/trap.c
434

I'd drop the do_ from this name.

439

This should be if ((exception & ISS_DATA_TFV) != 0) { (and similar below)

608

Do we need to restore the VFP state? It should be enabled when this exception is raised.

sys/arm64/include/armreg.h
299–306

These should be named something like ISS_FP_TFV_FOO and placed before the ISS_INSN_* definitions. The ISS_DATA_* macros are for data aborts.

dchagin updated this revision to Diff 106159.May 19 2022, 11:25 AM

fixed, thank you

Harbormaster completed remote builds in B45630: Diff 106159.May 19 2022, 11:25 AM
dchagin marked 4 inline comments as done.May 19 2022, 11:28 AM
dchagin added inline comments.
sys/arm64/arm64/trap.c
608

yep, I should read Architecture Reference Manual before

sys/arm64/include/armreg.h
299–306

I'd prefer ISS_FP_FOO as TVF and FOO are bits in the same word, but if you insist, I'll change the naming

andrew accepted this revision.May 19 2022, 11:57 AM
This revision is now accepted and ready to land.May 19 2022, 11:57 AM
Closed by commit rG6e2caba7a129: arm64: Enable the floating-point exception traps (authored by dchagin). · Explain WhyMay 19 2022, 4:57 PM
This revision was automatically updated to reflect the committed changes.
dchagin marked 2 inline comments as done.
dchagin added a commit: rG6e2caba7a129: arm64: Enable the floating-point exception traps.
dchagin added a commit: rG570206bdc227: arm64: Enable the floating-point exception traps.Jun 17 2022, 7:46 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
31 lines
include/
8 lines
sys/
1 line

Diff 106144

View Options

sys/arm64/arm64/trap.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

sys/sys/signal.h

Loading...