Page MenuHomeFreeBSD
Differential D34844

LinuxKPI: add ALIGN_DOWN()
ClosedPublic
Actions

Authored by bz on Apr 8 2022, 3:31 PM.
Tags
None
Referenced Files
F166308567: D34844.diff
Wed, Aug 12, 7:42 PM
F166232544: D34844.id104784.diff
Wed, Aug 12, 12:19 PM
F166231476: D34844.id104780.diff
Wed, Aug 12, 12:14 PM
Unknown Object (File)
Wed, Aug 12, 7:23 AM
Unknown Object (File)
Tue, Aug 11, 11:07 AM
Unknown Object (File)
Mon, Aug 10, 8:49 AM
Unknown Object (File)
Fri, Aug 7, 10:37 PM
Unknown Object (File)
Thu, Aug 6, 11:50 AM
View All Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
manu
• hselasky
Group Reviewers
linuxkpi
Commits
rG94b9567f7568: LinuxKPI: add ALIGN_DOWN()
rG97f2e93a66a8: LinuxKPI: add ALIGN_DOWN()
Summary

Add ALIGN_DOWN as rounddown2() along ALIGN() which is implemented as
roundup2().

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Apr 8 2022, 3:31 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 8 2022, 3:31 PM
bz requested review of this revision.Apr 8 2022, 3:31 PM
Harbormaster completed remote builds in B45077: Diff 104767.Apr 8 2022, 3:32 PM
manu accepted this revision.Apr 8 2022, 3:38 PM
This revision is now accepted and ready to land.Apr 8 2022, 3:38 PM
• hselasky accepted this revision.Apr 8 2022, 4:08 PM
• hselasky added a subscriber: • hselasky.

This will do too:

#define	ALIGN_DOWN(x, y)	rounddown2(x, y)

Too many ()'s in my opinion.

--HPS

bz updated this revision to Diff 104780.Apr 8 2022, 4:16 PM

Rmeove extra () ().

This revision now requires review to proceed.Apr 8 2022, 4:16 PM
Harbormaster completed remote builds in B45079: Diff 104780.Apr 8 2022, 4:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2022, 6:29 PM
Closed by commit rG97f2e93a66a8: LinuxKPI: add ALIGN_DOWN() (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG97f2e93a66a8: LinuxKPI: add ALIGN_DOWN().
bz added a commit: rG94b9567f7568: LinuxKPI: add ALIGN_DOWN().Apr 14 2022, 6:03 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line

Diff 104784

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...