Page MenuHomeFreeBSD
Differential D34482

pf: support basic L3 filtering in the Ethernet rules
ClosedPublic
Actions

Authored by kp on Mar 8 2022, 5:23 PM.
Tags
None
Referenced Files
F82732058: D34482.diff
Thu, May 2, 2:24 AM
Unknown Object (File)
Mar 22 2024, 10:44 AM
Unknown Object (File)
Mar 22 2024, 10:02 AM
Unknown Object (File)
Mar 22 2024, 9:43 AM
Unknown Object (File)
Mar 22 2024, 9:43 AM
Unknown Object (File)
Mar 12 2024, 4:18 PM
Unknown Object (File)
Feb 10 2024, 1:44 AM
Unknown Object (File)
Jan 29 2024, 1:37 AM
View All 36 Files
Subscribers
ae
debdrup
farrokhi
glebius
imp
melifaro
pauamma_gundo.com

Details

Reviewers
debdrup
pauamma_gundo.com
Group Reviewers
network
pfsense
manpages
Commits
rG8a42005d1e49: pf: support basic L3 filtering in the Ethernet rules
Summary

Allow filtering based on the source or destination IP/IPv6 address in
the Ethernet layer rules.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44723
Build 41611: arc lint + arc unit

Event Timeline

kp created this revision.Mar 8 2022, 5:23 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 8 2022, 5:23 PM
Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald Transcript
kp requested review of this revision.Mar 8 2022, 5:23 PM
kp added a child revision: D34483: pf tests: Test new L3 inspection for pf 'ether' rules.
Harbormaster completed remote builds in B44692: Diff 103635.Mar 8 2022, 5:24 PM
debdrup accepted this revision.Mar 8 2022, 9:26 PM
debdrup added a subscriber: debdrup.

Please remember to bump .Dd on pf.conf.5 - other than that, manual page looks fine.

This revision is now accepted and ready to land.Mar 8 2022, 9:26 PM
pauamma_gundo.com accepted this revision.Mar 8 2022, 11:30 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Other than the needed bump, manual page change LGTM

share/man/man5/pf.conf.5
31

Needs bumping..

kp updated this revision to Diff 103678.Mar 9 2022, 10:18 AM

Bump man page date

This revision now requires review to proceed.Mar 9 2022, 10:18 AM
Harbormaster completed remote builds in B44723: Diff 103678.Mar 9 2022, 10:18 AM
pauamma_gundo.com added a comment.Mar 10 2022, 4:33 AM

Manual page LGTM now. Holding back until someone opines on consistency with parser (and correctness of rest of source code change).

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2022, 9:44 PM
Closed by commit rG8a42005d1e49: pf: support basic L3 filtering in the Ethernet rules (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG8a42005d1e49: pf: support basic L3 filtering in the Ethernet rules.

Revision Contents
Changeset List

PathSize
lib/
libpfctl/
1 line
10 lines
sbin/
pfctl/
63 lines
7 lines
share/
man/
man5/
4 lines
sys/
net/
1 line
netpfil/
pf/
64 lines
30 lines

Diff 103678

View Options

lib/libpfctl/libpfctl.h

Loading...
View Options

lib/libpfctl/libpfctl.c

Loading...
View Options

sbin/pfctl/parse.y

Loading...
View Options

sbin/pfctl/pfctl_parser.c

Loading...
View Options

share/man/man5/pf.conf.5

Loading...
View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_nv.c

Loading...